From nobody Wed Jun 3 16:06:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gVsxy3JLPz6g8j3; Wed, 03 Jun 2026 16:06:14 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gVsxy1gY6z3qbw; Wed, 03 Jun 2026 16:06:14 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780502774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zWeOPdFg9kD/eRBK0RTjFnOWMIUwI8A6Ug8HknVy4lc=; b=FZ/KBE2AdXlvCRQoHS9Bw2hTahIRXt/aDws264S00iq+yxGngdI1QUmdQJTpuVp5Y9PttY P47mLBcPDNiJNrXH9PJvmLt9ro8CH8Me4Mk/hwzR4zmK5MfrVG0n52agwUwPYEDhdxHSjm pv0tUmt8tPD/DK/kceZt3p+w6Lrg/gT4YC4GWurNQZvAaJl7gU8x1jLiAYoeiREq7MB6xZ q3rvNppHhatofk9IIaV5XULlZvc0vv2Cc7yNRMI0e9YjrjuquUh+xnGNWUmRd3k6oJL8sN 3En3SFyZgqFKDAdttq6TEjtqogIM43OCTtxcyqOyhQDswVme9CREoGN3702TjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780502774; a=rsa-sha256; cv=none; b=U8PfFD2b458iEUC1qYa787XPetfOGEpT6OE9slsdJtJXjd/Yzpgqq81Ff1Mq7b7CUvQwiC PQPYugGqXOA/cgZL27/yMj/cTNLQFqKP85lo3q+1SpYvuP1jAwMJvu2C+hC/+3PEQNF3Cm hNgHsg4WfXUnJ6LYDNWlHl4DbrupXStLuouLIl1mbWudqfGeG2bGFbGXZljQ0W+4qrcFWd nOQm6HsSHZavsJknDV6vlydClnMBCbNi+0ukNyyNtv41rmEZyoaJxgOUxGWIyUG8APH3Do YWpvVTZUz4Rt735SMOkvTJJVhqWbdLWorAKFPQsggj9cr39Mezhhobhqf4Qn9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780502774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zWeOPdFg9kD/eRBK0RTjFnOWMIUwI8A6Ug8HknVy4lc=; b=E+54pCm9jo7efawKpuM5WtWFm5i2Dj/079++dApFqjPWcPr+nIIcC9b65WXlOq7UyOmmLK FH+sWhMTnUrEyIBxDqVV0Lm0Oigc3VbdZZDHxRTPnWI04eOC0QdUZDKVBAsrXUb8YTkyYa mkoXs/qjT5WSFeHhCxGDlzlwaP1gcUaOmBmQ0fJk8G6aAUYbobeNiD+5KxsbY1HUXN0I6g td9fCbKeZXhPucIn79Af8oiJtW6Nw7+wUfOn3Cmx1vhfqZdypDFBJr5nGIH3YX/yQ6FF1D jKzzQaNeWTGocioBaClRaUSdg046WprgBzVA+IOVYRXQ7b3aXYr60VnhQGkQyA== Received: from ravel.localnet (lfbn-nic-1-328-19.w90-116.abo.wanadoo.fr [90.116.162.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gVsxx2YXDzJXc; Wed, 03 Jun 2026 16:06:13 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Enji Cooper , src-committers@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Dag-Erling =?UTF-8?B?U23DuHJncmF2?= Subject: Re: git: 886164895f3f - main - amd64: complete thunderbolt KERNCONF integration Date: Wed, 03 Jun 2026 18:06:05 +0200 Message-ID: <3174612.hHqAuc6tWs@ravel> In-Reply-To: <86wlwgue2o.fsf@ltc.des.dev> References: <6a1fc36c.20f4d.2792bff2@gitrepo.freebsd.org> <86wlwgue2o.fsf@ltc.des.dev> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2520476.THHZn3L5Ee"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart2520476.THHZn3L5Ee Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner To: Enji Cooper , src-committers@freebsd.org Date: Wed, 03 Jun 2026 18:06:05 +0200 Message-ID: <3174612.hHqAuc6tWs@ravel> In-Reply-To: <86wlwgue2o.fsf@ltc.des.dev> MIME-Version: 1.0 Hi Enji, > > commit 886164895f3f4805dc11171ac7980acaccf6ec77 > > Author: Enji Cooper > > AuthorDate: 2026-06-03 06:02:01 +0000 > > Commit: Enji Cooper > > CommitDate: 2026-06-03 06:02:01 +0000 > > > > amd64: complete thunderbolt KERNCONF integration > > > > This completes the work so the driver can be integrated into KERNCONFs > > properly on amd64. > > > > MFC after: 1 month > > > > Differential Revision: https://reviews.freebsd.org/D55573 > > /usr/src/sys/dev/thunderbolt/router.c:281:6: error: variable 'up' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/router.c:723:8: error: variable 'adap' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/nhi.c:837:20: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/nhi.c:871:20: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/nhi.c:874:8: error: variable 'len' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/tb_acpi_pcib.c:123:15: error: variable 's' set but not used [-Werror,-Wunused-but-set-variable] > /usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6: error: variable 'error' set but not used [-Werror,-Wunused-but-set-variable] Compilation fails on INVARIANTS, it works with !INVARIANTS. Was bitten by such a case relatively recently. Try not to forget to build both cases when fiddling with debug code. Fixed in 9a133eee1ed9cf32. Amend as you see fit. Regards. -- Olivier Certner --nextPart2520476.THHZn3L5Ee Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmogUO4ACgkQjKEwQJce JicLJw//YZNDyejTzZP88Uanm628qnXLWCczFy4qiJJ4WfhmfGahlnOq03uzBhwo w6ssuLyTXpMSmhYn2998I8LpDZNuv05QPRgi2MtmEUCTqDWCV/6ea3+/GmtMMpDT oo94moiprS26FWZE+n21+uYhmyKdPft5PrUyUmQQdDqHQutp6v6JjA4sYUn35HIQ BZ/ikShVvi0js2bxpQmOQiCpgXW1ZRSBkgWsPOoemBjnv2XyDzni9NQsc8fL+f4q GShYIvus2+gFIRYyNdP45aDaAu4mYwSPaD/8n13sk/EV3cBMKukPojPt7jDUMZw/ NgdcdcNtpT0F/VnMpRIg+00T7AezKOJBhdMoZPB67qGCININd4OkFQBlOqYwpnWJ meoN8/NjAKQBQuvXxA6B4/yk2OKwawSudKSwHeKfyJRLL74E2a77eJZ2EXP9M55P ctbKfIBDNws+vUqepnieA8wt8AXsLdEKm2+SnvblnFa2qNCk5dmyVUR4lqtVlFcc +DjA2noK9Y65i+teK1KZKKa/FIRd5tJiWrBfbQdQcWyxBFIl6dHZnsoy2w3aOH1z 9YL11SjemFxNTWef6ghWRy123MZIlspA3JADzQHIuzOeBxHDJGTuw73pV1WxikAK niMw1wN/XFLbCeQlKWDRaLJRv0GeUwT/GbR0uvPKP6tMzu3xi5M= =Fw5d -----END PGP SIGNATURE----- --nextPart2520476.THHZn3L5Ee--