From owner-svn-ports-all@freebsd.org Sat Sep 15 17:22:05 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F90410AAB67; Sat, 15 Sep 2018 17:22:05 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44E1D924B3; Sat, 15 Sep 2018 17:22:05 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3FC2B166F2; Sat, 15 Sep 2018 17:22:05 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w8FHM58c023490; Sat, 15 Sep 2018 17:22:05 GMT (envelope-from emaste@FreeBSD.org) Received: (from emaste@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w8FHM5Gm023445; Sat, 15 Sep 2018 17:22:05 GMT (envelope-from emaste@FreeBSD.org) Message-Id: <201809151722.w8FHM5Gm023445@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: emaste set sender to emaste@FreeBSD.org using -f From: Ed Maste Date: Sat, 15 Sep 2018 17:22:05 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r479840 - head/multimedia/xmms X-SVN-Group: ports-head X-SVN-Commit-Author: emaste X-SVN-Commit-Paths: head/multimedia/xmms X-SVN-Commit-Revision: 479840 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Sep 2018 17:22:05 -0000 Author: emaste (src committer) Date: Sat Sep 15 17:22:04 2018 New Revision: 479840 URL: https://svnweb.freebsd.org/changeset/ports/479840 Log: multimedia/xmms: add -znotext to LDFLAGS on i386, for lld Example error: /usr/bin/ld: error: can't create dynamic relocation R_386_32 against local symbol in readonly segment; recompile object files with -fPIC This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default. Modified: head/multimedia/xmms/Makefile Modified: head/multimedia/xmms/Makefile ============================================================================== --- head/multimedia/xmms/Makefile Sat Sep 15 16:13:49 2018 (r479839) +++ head/multimedia/xmms/Makefile Sat Sep 15 17:22:04 2018 (r479840) @@ -23,6 +23,9 @@ USE_GNOME= gtk12 USE_LDCONFIG= yes USE_XORG= sm x11 xxf86vm +LDFLAGS+= ${LDFLAGS_${ARCH}} +LDFLAGS_i386= -Wl,-znotext + CONFIGURE_ARGS= xmms_cv_newpcm_driver=yes --disable-static CONFIGURE_ENV= INPUT_PLUGINS="${INPUT_PLUGINS}" \ OUTPUT_PLUGINS="${OUTPUT_PLUGINS}" \