From owner-freebsd-current  Wed Aug 26 02:10:14 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id CAA28351
          for freebsd-current-outgoing; Wed, 26 Aug 1998 02:10:14 -0700 (PDT)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from ren.dtir.qld.gov.au (ns.dtir.qld.gov.au [203.108.138.66])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA28336
          for <freebsd-current@freebsd.org>; Wed, 26 Aug 1998 02:10:10 -0700 (PDT)
          (envelope-from syssgm@dtir.qld.gov.au)
Received: by ren.dtir.qld.gov.au; id TAA27328; Wed, 26 Aug 1998 19:09:17 +1000 (EST)
Received: from ogre.dtir.qld.gov.au(167.123.8.3) by ren.dtir.qld.gov.au via smap (3.2)
	id xma027321; Wed, 26 Aug 98 19:09:03 +1000
Received: from atlas.dtir.qld.gov.au (atlas.dtir.qld.gov.au [167.123.8.9])
	by ogre.dtir.qld.gov.au (8.8.8/8.8.7) with ESMTP id TAA11892;
	Wed, 26 Aug 1998 19:09:03 +1000 (EST)
Received: from nymph.dtir.qld.gov.au (nymph.dtir.qld.gov.au [167.123.10.10])
	by atlas.dtir.qld.gov.au (8.8.5/8.8.5) with ESMTP id TAA13971;
	Wed, 26 Aug 1998 19:09:02 +1000 (EST)
Received: from nymph.dtir.qld.gov.au (localhost.dtir.qld.gov.au [127.0.0.1])
	by nymph.dtir.qld.gov.au (8.8.8/8.8.7) with ESMTP id TAA11802;
	Wed, 26 Aug 1998 19:09:01 +1000 (EST)
	(envelope-from syssgm@nymph.dtir.qld.gov.au)
Message-Id: <199808260909.TAA11802@nymph.dtir.qld.gov.au>
To: Doug Rabson <dfr@nlsystems.com>
cc: freebsd-current@FreeBSD.ORG, syssgm@dtir.qld.gov.au
Subject: Re: Serious bug in vm_page.h in current 
References: <Pine.BSF.4.01.9808260953170.17263-100000@herring.nlsystems.com>
In-Reply-To: <Pine.BSF.4.01.9808260953170.17263-100000@herring.nlsystems.com>
    from Doug Rabson at "Wed, 26 Aug 1998 09:54:08 +0100"
Date: Wed, 26 Aug 1998 19:09:00 +1000
From: Stephen McKay <syssgm@dtir.qld.gov.au>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wednesday, 26th August 1998, Doug Rabson wrote:

>How about this:
>
>Index: vm_page.h
>===================================================================

>+static __inline void
>+vm_page_busy(vm_page_t m)
>+{
>+	vm_page_busy(m);
> }

An "oops"?  Otherwise looking good.

But to be picky, I prefer vm_page_flag_clear() and vm_page_flag_set() to
vm_page_clear_flag() and vm_page_set_flag().  Similarly, I think that
vm_page_io_start() and vm_page_io_finish() would be better than
vm_page_start_io() and vm_page_finish_io().  I hope you can see my
reasoning.

But, I'm not going to arm wrestle you for it if you don't like it.

Stephen.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message