From owner-cvs-all@FreeBSD.ORG Mon Oct 11 18:39:16 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1100C16A4CF for ; Mon, 11 Oct 2004 18:39:16 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE84843D39 for ; Mon, 11 Oct 2004 18:39:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 15418 invoked from network); 11 Oct 2004 18:39:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 11 Oct 2004 18:39:15 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i9BIdBmm041427; Mon, 11 Oct 2004 14:39:11 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Brian Feldman Date: Mon, 11 Oct 2004 13:56:56 -0400 User-Agent: KMail/1.6.2 References: <200410090816.i998Gbs5076009@repoman.freebsd.org> In-Reply-To: <200410090816.i998Gbs5076009@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200410111356.56415.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2004 18:39:16 -0000 On Saturday 09 October 2004 04:16 am, Brian Feldman wrote: > green 2004-10-09 08:16:37 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_witness.c > Log: > Don't "implicitly order all sleep locks before spin locks" in witness > when the spin lock in question isn't -- it's the critical_enter() that > KDB set. No more panic in DDB for console -> syscons -> tty -> knote > operations. Thanks for breaking witness. A better choice would be to fix kdb_printf() instead of just papering over the problem. Having KDB block on a lock will have all sorts of bad results and all this does is hide the warning. Please revert. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org