Date: Fri, 8 Apr 2022 22:44:34 -0500 From: Kyle Evans <kevans@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: [RFC] patch's default backup behavior Message-ID: <CACNAnaFi2Ee5M5bX=FoaV-h=nC0kVrpEBqzuyG8SQhJeqkto3g@mail.gmail.com> In-Reply-To: <CANCZdfopEmCaszMx%2B%2B15irhZLvZz=aQrG5YStyMzVxU=8EFQvg@mail.gmail.com> References: <CACNAnaGTZSGKP=FKT1deAjJ0W=Q5Ezqf0ZinC2ydDzUksk%2BFtw@mail.gmail.com> <CANCZdfopEmCaszMx%2B%2B15irhZLvZz=aQrG5YStyMzVxU=8EFQvg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 8, 2022 at 10:41 PM Warner Losh <imp@bsdimp.com> wrote: > > > > On Fri, Apr 8, 2022, 9:26 PM Kyle Evans <kevans@freebsd.org> wrote: >> >> Hello! >> >> FreeBSD's patch follows historical patch(1) behavior w.r.t. backups, >> where a backup is created for every file patched. >> >> I'd like to test the waters on switching this to the GNU behavior, >> which feels a whole lot more reasonable. Notably, they'll only create >> backup files if a mismatch was detected (presumably this means either >> a hunk needed fuzz or a hunk outright failed). This yields far fewer >> backup files in the ideal scenario (context entirely matches), while >> still leaving backup files when it's sensible (base file changed and >> we might want to regenerate the patch). >> >> Thoughts / comments / concerns? Cross-posted this to a couple of >> different lists to try and hit the largest number of stakeholders in >> patch(1) behavior. > > > Could one select the old behavior? Or would it just be a change? A new -V value? > Yeah, the current behavior is actually represented by the `-b` flag. With the new behavior, we'd specifically implement `--backup-if-mismatch` (a nop from the beginning), `--no-backup-if-mismatch` (turn off backups, equivalent to `-V none` but "lighter" in that it won't override -b/-V) and we'd leave existing flags otherwise alone. > I like the Idea. > > Warner > >> Thanks, >> >> Kyle Evans >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFi2Ee5M5bX=FoaV-h=nC0kVrpEBqzuyG8SQhJeqkto3g>