From owner-freebsd-bugs@freebsd.org Thu Aug 3 13:05:57 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2C40DB7800 for ; Thu, 3 Aug 2017 13:05:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C094476E31 for ; Thu, 3 Aug 2017 13:05:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v73D5vo7066698 for ; Thu, 3 Aug 2017 13:05:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221201] [pf] Prevent possible endless loop when searching for an unused nat port Date: Thu, 03 Aug 2017 13:05:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch, security X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fk@fabiankeil.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable10? mfc-stable11? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 13:05:57 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221201 Bug ID: 221201 Summary: [pf] Prevent possible endless loop when searching for an unused nat port Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch, security Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: fk@fabiankeil.de Flags: mfc-stable10?, mfc-stable11? Created attachment 184989 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184989&action= =3Dedit pf_pf_get_sport(): Prevent possible endless loop when searching for an unus= ed nat port Attached is a "port" of Alexander Bluhm's OpenBSD commit r1.60. The first chunk had to be modified because on OpenBSD the 'cut' declaration is located elsewhere. OpenBSD commit message: Use a 32 bit variable to detect integer overflow when searching for an unused nat port. Prevents a possible endless loop if high port is 65535 or low port is 0. report and analysis Jingmin Zhou; OK sashan@ visa@ Quoted from: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/net/pf_lb.c Upstream report by Jingmin Zhou: https://marc.info/?l=3Dopenbsd-pf&m=3D150020133510896&w=3D2 Obtained from: OpenBSD via ElectroBSD --=20 You are receiving this mail because: You are the assignee for the bug.=