Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Aug 2006 14:52:23 +0400
From:      Boris Samorodov <bsam@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/101809: [patch] bsd.port.mk: add missing "|| true" command
Message-ID:  <E1GBUcp-000OPM-Km@ns.kfs.ru>
Resent-Message-ID: <200608111100.k7BB0VvB068715@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         101809
>Category:       ports
>Synopsis:       [patch] bsd.port.mk: add missing "|| true" command
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 11 11:00:31 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Boris B. Samorodov
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
InPharmTech Co., http://www.ipt.ru
>Environment:
System: FreeBSD serv3.int.kfs.ru 6.0-STABLE FreeBSD 6.0-STABLE #0: Wed Nov 23 23:34:00 MSK 2005 bsam@serv3.int.kfs.ru:/usr/obj/usr/src/sys/SERV3 i386

>Description:
	While testing a patch for lang/gnat-gcc34 to unbreak it at 4.x, I get
	an error at the thinderbox:
	====================<phase 7: make package>====================
	===>  Building package for gnat-gcc-3.4.6
	Creating package /tmp/packages/All/gnat-gcc-3.4.6.tgz
	Registering depends: ldconfig_compat-1.0_8 rc_subr-1.31_1.
	Registering conflicts: gcc-3.4.*.
	Creating gzip'd tar ball in '/tmp/packages/All/gnat-gcc-3.4.6.tgz'
	Deleting gnat-gcc-3.4.6
	pkg_delete: unexec command for 'rmdir libdata/ldconfig >/dev/null 2>&1' failed  [1]
	pkg_delete: couldn't entirely delete package (perhaps the packing list is
	incorrectly specified?)

	I assume that this command (@unexec) and it's output to STDOUT and
	STDERR redirecting to /dev/null were added to bsd.port.mk to
	avoid such errors. But the last part (|| true) was not added
	by accident.

>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.539
diff -u -r1.539 bsd.port.mk
--- bsd.port.mk	4 Aug 2006 12:34:41 -0000	1.539
+++ bsd.port.mk	11 Aug 2006 09:19:03 -0000
@@ -3858,7 +3858,7 @@
 		> ${PREFIX}/${LDCONFIG_DIR}/${UNIQUENAME}
 	@${ECHO_CMD} ${LDCONFIG_DIR}/${UNIQUENAME} >> ${TMPPLIST}
 .if defined(NO_LDCONFIG_MTREE)
-	@${ECHO_CMD} "@unexec rmdir ${LDCONFIG_DIR} >/dev/null 2>&1" >> ${TMPPLIST}
+	@${ECHO_CMD} "@unexec rmdir ${LDCONFIG_DIR} >/dev/null 2>&1 || true" >> ${TMPPLIST}
 .endif
 .endif
 .endif

WBR
-- 
bsam
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1GBUcp-000OPM-Km>