From owner-freebsd-stable@freebsd.org Tue Feb 12 20:13:40 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9968514CF34A; Tue, 12 Feb 2019 20:13:40 +0000 (UTC) (envelope-from srs0=cpp7=qt=vega.codepro.be=kp@codepro.be) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 493AC807AB; Tue, 12 Feb 2019 20:13:38 +0000 (UTC) (envelope-from srs0=cpp7=qt=vega.codepro.be=kp@codepro.be) Received: from vega.codepro.be (unknown [172.16.1.3]) by venus.codepro.be (Postfix) with ESMTP id C02AC10AB7; Tue, 12 Feb 2019 21:13:30 +0100 (CET) Received: by vega.codepro.be (Postfix, from userid 1001) id BDA152C2CA; Tue, 12 Feb 2019 21:13:30 +0100 (CET) Date: Tue, 12 Feb 2019 21:13:30 +0100 From: Kristof Provost To: Eric van Gyzen Cc: Pete French , "Andrey V. Elsukov" , freebsd-stable@freebsd.org, freebsd-current Subject: Re: Networking panic on 12 - found the cause Message-ID: <20190212201330.GK8450@vega.codepro.be> References: <4a350f47-eaca-5aca-9268-bf7a6618e71c@yandex.ru> <0a0f2668-19f7-ad62-dff4-e2997e57ea5c@vangyzen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0a0f2668-19f7-ad62-dff4-e2997e57ea5c@vangyzen.net> X-Checked-By-NSA: Probably User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 493AC807AB X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of srs0=cpp7=qt=vega.codepro.be=kp@codepro.be designates 5.9.86.228 as permitted sender) smtp.mailfrom=srs0=cpp7=qt=vega.codepro.be=kp@codepro.be X-Spamd-Result: default: False [-5.62 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:5.9.86.228]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[228.86.9.5.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[mx2.codepro.be,mx1.codepro.be]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; IP_SCORE(-2.43)[ip: (-8.04), ipnet: 5.9.0.0/16(-1.87), asn: 24940(-2.24), country: DE(-0.01)]; FORGED_SENDER(0.30)[kp@freebsd.org,srs0=cpp7=qt=vega.codepro.be=kp@codepro.be]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:5.9.0.0/16, country:DE]; FROM_NEQ_ENVFROM(0.00)[kp@freebsd.org, srs0=cpp7=qt=vega.codepro.be=kp@codepro.be] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 20:13:40 -0000 On 2019-02-12 13:54:21 (-0600), Eric van Gyzen wrote: > I see the same behavior on head (and stable/12). > > (kgdb) f > #16 0xffffffff80ce5331 in ether_output_frame (ifp=0xfffff80003672800, > m=0xfffff8000c88b100) at /usr/src/sys/net/if_ethersubr.c:468 > 468 switch (pfil_run_hooks(V_link_pfil_head, &m, ifp, PFIL_OUT, > > 0xffffffff80ce5321 <+81>: mov %gs:0x0,%rax > 0xffffffff80ce532a <+90>: mov 0x500(%rax),%rax > => 0xffffffff80ce5331 <+97>: mov 0x28(%rax),%rax > > I think this is part of the V_link_pfil_head. I'm not very familiar > with vnet. Does this need a CURVNET_SET(), maybe in garp_rexmit()? > Yes. I posted a proposed patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235699 Basically we get called through a timer, so there's no vnet context. It needs to be set, and then we can safely use any V_ variables. Regards, Kristof