From owner-svn-src-stable@freebsd.org Sat Jun 27 20:46:34 2020 Return-Path: Delivered-To: svn-src-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 48F8035BFD4; Sat, 27 Jun 2020 20:46:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49vQlZ0y35z4Qt4; Sat, 27 Jun 2020 20:46:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 16643248E1; Sat, 27 Jun 2020 20:46:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f171.google.com with SMTP id j80so12047131qke.0; Sat, 27 Jun 2020 13:46:34 -0700 (PDT) X-Gm-Message-State: AOAM5316RRJDnx8VMmsiSuYo+IyJpcNUbZgxk2VjJo2aiLAHrZZSIWdD N6RM8Rc580HS1T2VaWEEQ7JoEHl3e3e/UAF1YKQ= X-Google-Smtp-Source: ABdhPJxGjyiWwAJF4P8h0H5tjxjEr1XF/6ch5gbbMVpXUUQTC9ly6fJRsipIpeZP+q68/6nj4312Nbx1ivqJ/O+SOgk= X-Received: by 2002:a37:bcb:: with SMTP id 194mr9078751qkl.103.1593290793401; Sat, 27 Jun 2020 13:46:33 -0700 (PDT) MIME-Version: 1.0 References: <202006271427.05RERbw3073838@repo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Sat, 27 Jun 2020 15:46:21 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r362687 - in stable/12/usr.bin/sed: . tests To: Li-Wen Hsu Cc: Mateusz Piotrowski <0mp@freebsd.org>, src-committers , svn-src-all , svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 20:46:34 -0000 (sorry, on mobile) This line needs dropped: + atf_add_test_case hex_subst It'll get added back in later when I merge that test back. On Sat, Jun 27, 2020, 15:03 Li-Wen Hsu wrote: > On Sat, Jun 27, 2020 at 10:27 PM Mateusz Piotrowski <0mp@freebsd.org> > wrote: > > > > Author: 0mp (doc,ports committer) > > Date: Sat Jun 27 14:27:37 2020 > > New Revision: 362687 > > URL: https://svnweb.freebsd.org/changeset/base/362687 > > > > Log: > > MFC 362017, 362039, 362071: > > > > Read commands from stdin when -f - is passed to sed(1) > > > > This patch teaches sed to interpret a "-" in a special way when given > > as an argument to the -f flag. > > > > This behavior is also present in GNU sed. > > > > PR: 244872 > > Tested by: antoine (exp-run) > > Reviewed by: pfg, tobik (older version) > > Approved by: pfg (src) > > Relnotes: yes > > Differential Revision: https://reviews.freebsd.org/D24079 > > > > Remove duplicate lines from sed tests > > > > Reported by: yuripv > > Approved by: pfg (src) > > > > Remove some more duplicate test cases I accidentally committed > > > > Reported by: markj, yuripv > > Hi, > > I think this MFC and for 11's might have some issues. The test cases > under usr.bin.sed.sed2_test cannot be listed thus cannot be executed: > > > https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/2458/testReport/junit/usr.bin.sed/sed2_test/ > > https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-test/5150/testReport/junit/usr.bin.sed/sed2_test/ > > This is how they should look like: > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15686/testReport/usr.bin.sed/sed2_test/ > > You can try with `cd /usr/tests/usr.bin/sed && kyua list sed2_test`. > Please check if the merged sed2_test.sh needs adjusting. > > Thanks, > Li-Wen >