From owner-freebsd-current@freebsd.org Tue Jul 21 09:31:50 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 200C737D781; Tue, 21 Jul 2020 09:31:50 +0000 (UTC) (envelope-from zec@fer.hr) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9tdx0mzLz4P7V; Tue, 21 Jul 2020 09:31:48 +0000 (UTC) (envelope-from zec@fer.hr) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NanXPt7oZbM+77hSu91MACot7WIBh2LSL26QMYXGfvXP7p9A16Ph58650/LbHxIFOydapozZU+QXkkEFcGXZirRQgoGS8m5kk66Ocw/ugCtiJ9RZVZx7Kamgb5pd6rQwRVCHu7Ah3+bDmJ3VafpDNRHRvkKs/GTwA6I/eyS0LLFdRVAE2VhSAFnpP6pEf7ZBxKe/lTos0EejJeThh3RxJf9ALQ/4yvztD1hnbLJ+IvfVMzcm5WBcZvIlRek7KKGS0/E/AHTBet/LpghgwLzZ+FgFuHPRHViJeZttLRuvgfFA0PTkJ+5m7rENFbYFwnI4aWkg7Kirahu/fimtZuX4qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6OQ+xHFL+NVGQjN+5NApzHhlZANQLB2J2jnOaXuELc=; b=exa/ud0fKwly0CpnO922fZU1Bf3e7PHLs9O6RxbHyMbFqfEFWQdzPf6l9Yg3YZ31r9WbRFEj6AzhQaS50QdIXejF+pdjAsgeBBEG6/UsjiUbpg1gmXAlWwvE58yQ9rz7m36LQMOHJKLOByUBM7UpHCnVYHFNUaCKLoIyGXV2fyhp1sYA9B+TUl8ZF0C0zXhTasvmBLtaqrCCDHTDc7IrQY6WAH5Nq8r8yoj9HKX6tXTpLUGuu2Z0AWezhf5oI4y5nrGfpdYh2muMXfsVJzGYbvMBSGmF/GZJd6dB0tN4rIKz74jE6T8pgIdLSiHmBgZz6D2gaGVhu9M1GO6gAfrlKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fer.hr; dmarc=pass action=none header.from=fer.hr; dkim=pass header.d=fer.hr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ferhr.onmicrosoft.com; s=selector2-ferhr-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6OQ+xHFL+NVGQjN+5NApzHhlZANQLB2J2jnOaXuELc=; b=RDEkSkXyMvCFGhUgeqveWlic4azrYEddmjxXjmmG8HirYq7wk+gs9jbSHfdMq5qO8v04cPv9Q3wureiaREwZrrH3oIQzCOxLcauiUTLdOhRX//zE4x3FVr43D58JNfKJyyJh6R7hnX/teuxfpJ2ACPaWc2tNYi0gOE88E473QYU= Received: from VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) by VI1PR08MB4240.eurprd08.prod.outlook.com (2603:10a6:803:102::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 21 Jul 2020 09:31:46 +0000 Received: from VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::c8e:e335:c7:319b]) by VE1PR08MB4783.eurprd08.prod.outlook.com ([fe80::c8e:e335:c7:319b%3]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 09:31:46 +0000 Date: Tue, 21 Jul 2020 11:31:53 +0200 From: Marko Zec To: John-Mark Gurney Cc: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: Re: somewhat reproducable vimage panic Message-ID: <20200721113153.42d83119@x23> In-Reply-To: <20200721091654.GC4213@funkthat.com> References: <20200721091654.GC4213@funkthat.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) Content-Type: multipart/mixed; boundary="MP_/YcpTgPso.vPHN47rj82525a" X-ClientProxiedBy: ZR0P278CA0021.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::8) To VE1PR08MB4783.eurprd08.prod.outlook.com (2603:10a6:802:a9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from x23 (161.53.19.9) by ZR0P278CA0021.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Tue, 21 Jul 2020 09:31:45 +0000 X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd11.3) X-Originating-IP: [161.53.19.9] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2388a74f-27d6-488c-8eac-08d82d58e2ed X-MS-TrafficTypeDiagnostic: VI1PR08MB4240: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tpJ1w6RKmXaPj07Tz6fVijlzuLMZe9TEFyCrhsIuUTsTUs9XYZb0V+Xz6XkoVKWLChsaZQVf12h/SLyghY6chPWhx+mzR2a0EKhJ5sYPHacbATgHuMhqYuJDmUhVnk+evscyVBCdjq+4agucse5sS1/O266jntnmUlfVlV2UCIvrUUE0uzUZCY45YbIY7Is8psL8Cq42SmqiW8FaptXnGvP4oKXVW70s/dz3fBc7d00ATQv31TM4m5qAXBAyBxIivlWYB/5gMOqG8Iql9fIr2m8POmmNvALODr+3s09uQpzX6SW3H8YS/NCR3+UdllV1LgIdmKh825Ed9rFZA1Ypnw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4783.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(366004)(39850400004)(136003)(346002)(2906002)(83380400001)(8676002)(66616009)(33716001)(66556008)(5660300002)(235185007)(66946007)(66476007)(86362001)(1076003)(4326008)(3480700007)(316002)(478600001)(786003)(8936002)(9686003)(9576002)(6916009)(6496006)(55016002)(16526019)(26005)(44144004)(956004)(186003)(52116002)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: M2tPNUb44sICEOHdUk/d/4MgCqzw3fN/Dvbj1QEqUA7FB3M22lrdAHRMOy36HNPRx1LhN2QNaVmfq7nvTs5ullcORCHTlvQ4ZZDV+z+M0ttp3aiDRMd4Uuo0mVD3vzvafFDGPFe41MUG69I5qPaCOScO4xybbQNX+YS9SSH2o7f2GEGeS+0QlJ6Tzwj1axEyFABAo76wRcOecuAMpmICxaSGav9vl0qUk9Vr/pKu2sMsmgbmD9P26Us9n5g4xEUG0uqNs5YpRqyXIwiBNhcAgbaF60N8QWuuJlbJmsshqNRkmv2ZDJ+CuxHNXs5/Q0Vr4bY3nvgI/LG2FuDlIxOFl3uBOGprAa+6u2pEolqum9xC4Ky6m8sDEHk5ZJZWOEntM1X14I7Oc0C/vpLHu+oFPlJcVt++DRXHBzbOGJfXENI0CWfFXehBbKSrZbYFs1QsuZ7mT0IhTXLbCYbTKGbabkFOyCOxM9M08EjCF58q7Do= X-OriginatorOrg: fer.hr X-MS-Exchange-CrossTenant-Network-Message-Id: 2388a74f-27d6-488c-8eac-08d82d58e2ed X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4783.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 09:31:46.2315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ca71eddc-cc7b-4e5b-95bd-55b658e696be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qLz+iouXhfeXeLoRMAF1srRM3s2s+qbZHQIDabwGr/YuebXo80/l5U7+EbNEVDC6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4240 X-Rspamd-Queue-Id: 4B9tdx0mzLz4P7V X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ferhr.onmicrosoft.com header.s=selector2-ferhr-onmicrosoft-com header.b=RDEkSkXy; dmarc=none; spf=pass (mx1.freebsd.org: domain of zec@fer.hr designates 40.107.8.77 as permitted sender) smtp.mailfrom=zec@fer.hr X-Spamd-Result: default: False [-3.59 / 15.00]; NEURAL_HAM_MEDIUM(-1.01)[-1.005]; R_DKIM_ALLOW(-0.20)[ferhr.onmicrosoft.com:s=selector2-ferhr-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; HAS_ATTACHMENT(0.00)[]; DMARC_NA(0.00)[fer.hr]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_HAM_LONG(-1.03)[-1.029]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ferhr.onmicrosoft.com:+]; NEURAL_HAM_SHORT(-0.45)[-0.454]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.8.77:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_IN_DNSWL_LOW(-0.10)[40.107.8.77:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 09:31:50 -0000 --MP_/YcpTgPso.vPHN47rj82525a Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, 21 Jul 2020 02:16:55 -0700 John-Mark Gurney wrote: > I'm running: > FreeBSD test 13.0-CURRENT FreeBSD 13.0-CURRENT #0 r362596: Thu Jun 25 > 05:02:51 UTC 2020 > root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC > amd64 > > and I'm working on improve the if_ure driver. I've put together a > little script that I've attached that I'm using to test the driver.. > It puts a couple ue interfaces each into their own jail, configures > them, and tries to pass traffic. This assumes that the two interfaces > are connected together. > > Pretty regularly when destroying the jails, I get the following > panic: CURVNET_SET at /usr/src/sys/netinet/in_mcast.c:626 > inm_release() curvnet=0 vnet=0xfffff80154c82a80 Perhaps the attached patch could help? (disclaimer: not even compile-tested) Marko > (kgdb) #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 > #1 doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:394 > #2 0xffffffff80bc6250 in kern_reboot (howto=260) > at /usr/src/sys/kern/kern_shutdown.c:481 > #3 0xffffffff80bc66aa in vpanic (fmt=, ap= out>) at /usr/src/sys/kern/kern_shutdown.c:913 > #4 0xffffffff80bc6403 in panic (fmt=) > at /usr/src/sys/kern/kern_shutdown.c:839 > #5 0xffffffff80d6553b in inm_release (inm=0xfffff80029043700) > at /usr/src/sys/netinet/in_mcast.c:630 > #6 inm_release_task (arg=, pending=) > at /usr/src/sys/netinet/in_mcast.c:312 > #7 0xffffffff80c2521a in taskqueue_run_locked > (queue=0xfffff80003116b00) at /usr/src/sys/kern/subr_taskqueue.c:476 > #8 0xffffffff80c26294 in taskqueue_thread_loop (arg=) > at /usr/src/sys/kern/subr_taskqueue.c:793 > #9 0xffffffff80b830f0 in fork_exit ( > callout=0xffffffff80c26200 , > arg=0xffffffff81cf4f70 , > frame=0xfffffe0049e99b80) at /usr/src/sys/kern/kern_fork.c:1052 > #10 > (kgdb) > > I have the core files so I can get additional information. > > Let me know if you need any additional information. > --MP_/YcpTgPso.vPHN47rj82525a Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=in_mcast.diff Index: sys/netinet/in_mcast.c =================================================================== --- sys/netinet/in_mcast.c (revision 363386) +++ sys/netinet/in_mcast.c (working copy) @@ -309,8 +309,10 @@ IN_MULTI_LOCK(); SLIST_FOREACH_SAFE(inm, &inm_free_tmp, inm_nrele, tinm) { SLIST_REMOVE_HEAD(&inm_free_tmp, inm_nrele); + CURVNET_SET(inm->inm_ifp->if_vnet); MPASS(inm); inm_release(inm); + CURVNET_RESTORE(); } IN_MULTI_UNLOCK(); } --MP_/YcpTgPso.vPHN47rj82525a--