From owner-freebsd-bugs@freebsd.org Thu Jul 12 09:46:41 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E4381047D39 for ; Thu, 12 Jul 2018 09:46:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AEC6186940 for ; Thu, 12 Jul 2018 09:46:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 72B2A1047D35; Thu, 12 Jul 2018 09:46:40 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37EE81047D34 for ; Thu, 12 Jul 2018 09:46:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCA5D8693D for ; Thu, 12 Jul 2018 09:46:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 1D22B2632C for ; Thu, 12 Jul 2018 09:46:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6C9kc6I072295 for ; Thu, 12 Jul 2018 09:46:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6C9kci7072294 for bugs@FreeBSD.org; Thu, 12 Jul 2018 09:46:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229715] src/lib/libdevstat/devstat.c:760]: (style) Redundant condition Date: Thu, 12 Jul 2018 09:46:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dcb314@hotmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 09:46:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229715 Bug ID: 229715 Summary: src/lib/libdevstat/devstat.c:760]: (style) Redundant condition Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: dcb314@hotmail.com src/lib/libdevstat/devstat.c:760]: (style) Redundant condition: (matches[i].match_fields&DEVSTAT_MATCH_PASS)=3D=3D0. 'A || (!A && B)' is eq= uivalent to 'A || B' [src/lib/libdevstat/devstat.c:769]: (style) Redundant condition: (matches[i].match_fields&DEVSTAT_MATCH_PASS)=3D=3D0. 'A || (!A && B)' is eq= uivalent to 'A || B' Source code is if ((((matches[i].match_fields & DEVSTAT_MATCH_TYPE)!=3D0) && ((devices[j].device_type & DEVSTAT_TYPE_MASK) = =3D=3D (matches[i].device_type & DEVSTAT_TYPE_MASK= )) &&(((matches[i].match_fields & DEVSTAT_MATCH_PASS)!=3D0) || (((matches[i].match_fields & DEVSTAT_MATCH_PASS) =3D=3D 0) && ((devices[j].device_type & DEVSTAT_TYPE_PASS) =3D=3D 0))) && (--num_match_categories =3D=3D 0)) || (((matches[i].match_fields & DEVSTAT_MATCH_IF) = !=3D 0) && ((devices[j].device_type & DEVSTAT_TYPE_IF_MAS= K) =3D=3D (matches[i].device_type & DEVSTAT_TYPE_IF_MASK)) &&(((matches[i].match_fields & DEVSTAT_MATCH_PASS)!=3D0) || (((matches[i].match_fields & DEVSTAT_MATCH_PASS) =3D=3D 0) && ((devices[j].device_type & DEVSTAT_TYPE_PASS) =3D=3D 0))) && (--num_match_categories =3D=3D 0)) || (((matches[i].match_fields & DEVSTAT_MATCH_PASS)!=3D0) && ((devices[j].device_type & DEVSTAT_TYPE_PASS) = !=3D 0) && (--num_match_categories =3D=3D 0))) { 20 or so lines of if statement could IMHO do with some simplifying. --=20 You are receiving this mail because: You are the assignee for the bug.=