From owner-svn-src-stable@freebsd.org Mon Jun 29 06:48:35 2020 Return-Path: Delivered-To: svn-src-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3EC44340881; Mon, 29 Jun 2020 06:48:35 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49wJ3l0h0cz4Qbx; Mon, 29 Jun 2020 06:48:34 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from localhost ([127.0.0.1] helo=id.bluezbox.com) by id.bluezbox.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1jpnaj-000LrB-H6; Sun, 28 Jun 2020 23:48:34 -0700 Received: (from gonzo@localhost) by id.bluezbox.com (8.15.2/8.15.2/Submit) id 05T6mXhj084020; Sun, 28 Jun 2020 23:48:33 -0700 (PDT) (envelope-from gonzo@freebsd.org) X-Authentication-Warning: id.bluezbox.com: gonzo set sender to gonzo@freebsd.org using -f Date: Sun, 28 Jun 2020 23:48:33 -0700 From: Oleksandr Tymoshenko To: Li-Wen Hsu Cc: src-committers , svn-src-all , svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r362767 - in stable/12/usr.bin/mkimg: . tests Message-ID: <20200629064833.GA83997@bluezbox.com> References: <202006290034.05T0YBU7051105@repo.freebsd.org> <20200629062057.GA82989@bluezbox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD/11.2-RELEASE-p10 (amd64) User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Li-Wen Hsu (lwhsu@freebsd.org) wrote: > On Mon, Jun 29, 2020 at 2:21 PM Oleksandr Tymoshenko wrote: > > > > Li-Wen Hsu (lwhsu@freebsd.org) wrote: > > > On Mon, Jun 29, 2020 at 8:36 [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Rspamd-Queue-Id: 49wJ3l0h0cz4Qbx X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:14061, ipnet:45.55.0.0/19, country:US] X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 06:48:35 -0000 Li-Wen Hsu (lwhsu@freebsd.org) wrote: > On Mon, Jun 29, 2020 at 2:21 PM Oleksandr Tymoshenko wrote: > > > > Li-Wen Hsu (lwhsu@freebsd.org) wrote: > > > On Mon, Jun 29, 2020 at 8:36 AM Oleksandr Tymoshenko wrote: > > > > > > > > Author: gonzo > > > > Date: Mon Jun 29 00:34:11 2020 > > > > New Revision: 362767 > > > > URL: https://svnweb.freebsd.org/changeset/base/362767 > > > > > > > > Log: > > > > MFC r361935: > > > > > > > > Add VHDX support to mkimg(1) > > > > > > > > VHDX is the successor of Microsoft's VHD file format. It increases > > > > maximum capacity of the virtual drive to 64TB and introduces features > > > > to better handle power/system failures. > > > > > > > > VHDX is the required format for 2nd generation Hyper-V VMs. > > > > > > > > Reviewed by: marcel > > > > Differential Revision: https://reviews.freebsd.org/D25184 > > > > > > Some mkimg(1) tests are failing after this merge: > > > > > > https://ci.freebsd.org/job/FreeBSD-stable-12-amd64-test/2484/ > > > https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/2466/ > > > > > > Can you check if there are something related to tests also need merging? > > > > Ooops, sorry for the breakage. Should be fixed in 362772. The problem > > was different format for the reference images. I'll wait to check if > > the commit fixes the test suite on stable/12 for sure and commit fix > > for stable/11 then. > > Thank you for the quick analysis and fix. Perhaps mering the codes to > process the new format of the reference images can easy the process of > future update and MFH? Good point. I assumed it was global change, but looks like it's just mkimg format change. I'll look into merging it both to stable/12 (and reverting current fix) and stable/11. -- gonzo