From owner-cvs-all Mon Dec 10 19:41:53 2001 Delivered-To: cvs-all@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id 008B337B405; Mon, 10 Dec 2001 19:41:50 -0800 (PST) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id fBB3eDk29228; Mon, 10 Dec 2001 22:40:13 -0500 (EST) (envelope-from mike) Date: Mon, 10 Dec 2001 22:40:13 -0500 From: Mike Barcroft To: Warner Losh Cc: "David E. O'Brien" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exec.c kern_intr.c kern_sema.c subr_witness.c Message-ID: <20011210224013.O1956@espresso.q9media.com> References: <200112100540.fBA5eCl35471@freefall.freebsd.org> <200112110327.fBB3RuM24201@harmony.village.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112110327.fBB3RuM24201@harmony.village.org>; from imp@harmony.village.org on Mon, Dec 10, 2001 at 08:27:56PM -0700 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Warner Losh writes: > In message <200112100540.fBA5eCl35471@freefall.freebsd.org> "David E. O'Brien" writes: > : Repeat after me -- "Use of ANSI string concatenation can be bad." > > is the usual use for long printf lines OK? Yes. In this case, some people were exploiting GCC (2.95)'s misimplementation of __func__ as a constant, when in reality it must be defined as a static constant automatic. It appears they have corrected this in newer releases. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message