From owner-freebsd-current@FreeBSD.ORG  Mon Jun  7 14:57:51 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 82D9216A4CE; Mon,  7 Jun 2004 14:57:51 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 75A0043D2D; Mon,  7 Jun 2004 14:57:51 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id A7E0F5C82D; Mon,  7 Jun 2004 07:57:50 -0700 (PDT)
Date: Mon, 7 Jun 2004 07:57:50 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20040607145750.GB90021@elvis.mu.org>
References: <Pine.BSF.4.53.0406061932520.62813@e0-0.zab2.int.zabbadoz.net>
	<20040607114505.GQ12007@darkness.comp.waw.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040607114505.GQ12007@darkness.comp.waw.pl>
User-Agent: Mutt/1.4.2.1i
cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
cc: FreeBSD current mailing list <current@freebsd.org>
Subject: Re: vfs_syscalls / fhstatfs / suser()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2004 14:57:51 -0000

* Pawel Jakub Dawidek <pjd@FreeBSD.org> [040607 04:45] wrote:
> +> 
> +> 
> +> --- ./vfs_syscalls.c.orig	Sun Jun  6 19:32:23 2004
> +> +++ ./vfs_syscalls.c	Sun Jun  6 19:33:12 2004
> +> @@ -4128,11 +4128,6 @@ fhstatfs(td, uap)
> +>  	sp->f_flags = mp->mnt_flag & MNT_VISFLAGMASK;
> +>  	if ((error = VFS_STATFS(mp, sp, td)) != 0)
> +>  		return (error);
> +> -	if (suser(td)) {
> +> -		bcopy(sp, &sb, sizeof(sb));
> +> -		sb.f_fsid.val[0] = sb.f_fsid.val[1] = 0;
> +> -		sp = &sb;
> +> -	}
> +>  	return (copyout(sp, uap->buf, sizeof(*sp)));
> +>  }
> 
> I'm not sure what the intention was, but I think we should probably
> change first suser() to suser_cred(td->td_ucred, PRISON_ROOT) as leave
> second one.
> 
> PS. I'm CCing this to alfred@ who bring it from NetBSD.

That sounds right.

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684