From owner-p4-projects@FreeBSD.ORG Mon Sep 24 16:37:42 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 537AC16A41A; Mon, 24 Sep 2007 16:37:42 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1D24E16A469 for ; Mon, 24 Sep 2007 16:37:42 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe08.swip.net [212.247.154.225]) by mx1.freebsd.org (Postfix) with ESMTP id C75E813C48E for ; Mon, 24 Sep 2007 16:37:41 +0000 (UTC) (envelope-from hselasky@freebsd.org) X-Cloudmark-Score: 0.000000 [] Received: from [85.19.218.45] (account mc467741@c2i.net [85.19.218.45] verified) by mailfe08.swip.net (CommuniGate Pro SMTP 5.1.10) with ESMTPA id 622380816; Mon, 24 Sep 2007 17:37:38 +0200 From: Hans Petter Selasky To: ticso@cicely.de Date: Mon, 24 Sep 2007 17:37:52 +0200 User-Agent: KMail/1.9.7 References: <200709231625.l8NGPhaR097038@repoman.freebsd.org> <200709232113.34718.hselasky@freebsd.org> <20070924104320.GE38890@cicely12.cicely.de> In-Reply-To: <20070924104320.GE38890@cicely12.cicely.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709241737.53572.hselasky@freebsd.org> Cc: Perforce Change Reviews , "Constantine A. Murenin" Subject: Re: PERFORCE change 126745 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2007 16:37:42 -0000 On Monday 24 September 2007, Bernd Walter wrote: > On Sun, Sep 23, 2007 at 09:13:33PM +0200, Hans Petter Selasky wrote: > > Hi Constantine, > > > > Thanks for your input and I _know_ that my code is not 100% style > > compliant. Most of the style misbehaves are probably there due to the way > > my "xemacs" autoformatting behaves. And I love curly brackets and > > parenthesis, by the way :-) > > > > My plan is to clean up all the style stuff by a small C-program in the > > end, because doing it by hand is waste of my time. Probably it will take > > less time to write that program than the actual manual edit when we are > > talking about doing alot of edits. It wonders me if such a tool already > > exists, because the code is technically OK. > > There is indent(1) in src, but it doesn't produce 100% style(9) clean > code either. > I usually use it as a starting point for very ugly formated code. > I'm not shure it will make things easier in this special case, maybe > just different. > But very likely you can use it to automatically fix at least a few > common points. > Enhancing indent to produce style(9) code would be a great feature... Hi Bernd Walter, Yes, I think I will go for that. Start with "indent" as is and then extend the functionality. Some things I have in mind: Automatic __FBSDID() at top of C-files. Automatic "static prototypes". Automatic comments before every C-function is defined. Automatic use of typedefs when declaring certain device method functions: static device_attach_t my_attach; Automatically reorder the code so that it follows generic device driver layout. --HPS