From owner-p4-projects@FreeBSD.ORG  Tue Nov 11 03:13:44 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D448716A4D0; Tue, 11 Nov 2003 03:13:43 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 975E516A4CE; Tue, 11 Nov 2003 03:13:43 -0800 (PST)
Received: from westhost42.westhost.net (westhost42.westhost.net
	[216.71.84.238])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 97F7343FDD; Tue, 11 Nov 2003 03:13:42 -0800 (PST)
	(envelope-from mini@freebsd.org)
Received: from [172.16.0.241] (mulder.f5.com [205.229.151.150])
	by westhost42.westhost.net (8.11.6/8.11.6) with ESMTP id hABBDeo30424;
	Tue, 11 Nov 2003 05:13:41 -0600
In-Reply-To: <200311110815.hAB8FFYG011998@repoman.freebsd.org>
References: <200311110815.hAB8FFYG011998@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v606)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <1E3D0F61-1438-11D8-87D8-000A95CD3CF8@freebsd.org>
Content-Transfer-Encoding: 7bit
From: Jonathan Mini <mini@freebsd.org>
Date: Tue, 11 Nov 2003 03:13:46 -0800
To: Juli Mallett <jmallett@freebsd.org>
X-Mailer: Apple Mail (2.606)
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 41975 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2003 11:13:44 -0000

I will only wash my hands once...
I will only wash my hands once...
I will only wash my hands once...
I will only wash my hands once...

Ugh, this keyboard is disgusting!

On Nov 11, 2003, at 12:15 AM, Juli Mallett wrote:

> http://perforce.freebsd.org/chv.cgi?CH=41975
>
> Change 41975 by jmallett@jmallett_dalek on 2003/11/11 00:14:14
>
> 	Ignore obsessive-compulsive desire to sort includes and just
> 	commit something which further desorts and happens to make
> 	the kvtop command available.
>
> Affected files ...
>
> .. //depot/projects/mips/sys/mips/mips/db_interface.c#9 edit
>
> Differences ...
>
> ==== //depot/projects/mips/sys/mips/mips/db_interface.c#9 (text+ko) 
> ====
>
> @@ -44,6 +44,9 @@
>  #include <machine/locore.h>
>  #include <machine/mips_opcode.h>
>
> +#include <vm/vm.h>
> +#include <vm/pmap.h>
> +
>  #include <machine/db_machdep.h>
>  #include <ddb/ddb.h>
>  #include <ddb/db_access.h>
> @@ -301,23 +304,14 @@
>  	}
>  }
>
> -#if 0 /* XXX notyet */
> -DB_COMMAND(kvtob, db_kvtophys_cmd)
> +DB_COMMAND(kvtop, db_kvtophys_cmd)
>  {
>
>  	if (!have_addr)
>  		return;
> -	if (MIPS_KSEG2_START <= addr) {
> -		/*
> -		 * Cast the physical address -- some platforms, while
> -		 * being ILP32, may be using 64-bit paddr_t's.
> -		 */
> -		db_printf("0x%lx -> 0x%qx\n", addr,
> -		    (unsigned long long) kvtophys(addr));
> -	} else
> -		printf("not a kernel virtual address\n");
> +	db_printf("%#lx -> %#lx\n", (u_long)addr,
> +		  (u_long)pmap_kextract(addr));
>  }
> -#endif
>
>  #define	FLDWIDTH	10
>  #define	SHOW32(reg, name)						\
>
>
-- 
Jonathan Mini
mini@freebsd.org
http://www.freebsd.org