From owner-freebsd-bugs@FreeBSD.ORG  Tue Mar 14 12:28:06 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0B6B816A485;
	Tue, 14 Mar 2006 12:28:06 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CFD1B43D45;
	Tue, 14 Mar 2006 12:28:05 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from freefall.freebsd.org (rwatson@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2ECS5NL063111;
	Tue, 14 Mar 2006 12:28:05 GMT
	(envelope-from rwatson@freefall.freebsd.org)
Received: (from rwatson@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2ECS5Io063107;
	Tue, 14 Mar 2006 12:28:05 GMT (envelope-from rwatson)
Date: Tue, 14 Mar 2006 12:28:05 GMT
From: Robert Watson <rwatson@FreeBSD.org>
Message-Id: <200603141228.k2ECS5Io063107@freefall.freebsd.org>
To: rwatson@FreeBSD.org, freebsd-bugs@FreeBSD.org, rwatson@FreeBSD.org
Cc: 
Subject: Re: kern/94278: Crash with FIFOs and ktrace
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Mar 2006 12:28:06 -0000

Synopsis: Crash with FIFOs and ktrace

Responsible-Changed-From-To: freebsd-bugs->rwatson
Responsible-Changed-By: rwatson
Responsible-Changed-When: Tue Mar 14 12:26:08 UTC 2006
Responsible-Changed-Why: 

Grab ownership, since I've also been looking at this.  David, feel free to
grab it if you'd prefer.

My reading was that actually, the fifo code is at fault for not checking
if the fdidx argument to vop_open() is -1, which implies there isn't a
file descriptor in use, and that fifos there fore can't hook up to it.
This error path may require some tweaking -- I tried having Kris add a
patch along these lines, and he reported problems that I haven't yet
investigated.

Being able to feed ktrace data to a fifo is a useful thing, but will be
difficult to re-add in the world of vnode bypass, something we might want
to add a todo item for sometime.


http://www.freebsd.org/cgi/query-pr.cgi?pr=94278