From owner-svn-src-head@freebsd.org Mon Nov 2 22:25:01 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECF93A24028 for ; Mon, 2 Nov 2015 22:25:00 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CB53197B for ; Mon, 2 Nov 2015 22:25:00 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by lfbf136 with SMTP id f136so55343245lfb.0 for ; Mon, 02 Nov 2015 14:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clockworksquid.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=37LEEWI/rYKxWTokMKe/Dzj30G0++L8j3A1IZ+y3HsQ=; b=dh1ERGAR6sSl7Ut5U+S73MxUwlUiu3L370Mth7s89dEUkWGc1GKgfgxgon9NgEFhlq ZvqURz43ijj95u5CGUULUSipnI9+3zlPWT4jm+fOyZIwL4+oQIFNGKsbCAsCa5GE89QY 3yp+Wq7czfnIyjmk7XV7gxFc/0qwu7RnTnblc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=37LEEWI/rYKxWTokMKe/Dzj30G0++L8j3A1IZ+y3HsQ=; b=Kb1LaRXQkeYU5OBrBllht6r60Pf5gW/CmmohpO/5w9RmcgPMPhySGUa+pUOFz4+Edj JkFNYohLD3EQi/YRqOTql3ElSXShFSNOVm+Ww6bcVaFqp51UtTlLGWPxJJzKAP9yPFdX r7QVw70SxSqp4lprMb+/sYbeFDveVe5exrCeS6JhateKQhDMd1e0YVPEzYztA2MbfRBN 7bcBe1m9bp3HhrUqjyEs0uuyqVMw1BM8Lo64VhY4fqiR19sOzovJWjDde5JDtTByQMf8 AJYgWqcQTsYl7U62TiSdunBCoQuR3PpBkoZ3gWuHGO+2kZn0BWNmd099fy2O2p2Vlo+t TfeQ== X-Gm-Message-State: ALoCoQminG/tZirbKy4HDwNx5rDKGOU2arko1Ss6MtrVsa99LDf/1EoL63T/oE5/jnUD3qkNKaSK X-Received: by 10.112.119.133 with SMTP id ku5mr11174551lbb.1.1446503098632; Mon, 02 Nov 2015 14:24:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.205.34 with HTTP; Mon, 2 Nov 2015 14:24:39 -0800 (PST) In-Reply-To: <201511022121.tA2LL1wG061420@repo.freebsd.org> References: <201511022121.tA2LL1wG061420@repo.freebsd.org> From: Juli Mallett Date: Mon, 2 Nov 2015 14:24:39 -0800 Message-ID: Subject: Re: svn commit: r290276 - head/sys/net To: Randall Stewart Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 22:25:01 -0000 On Mon, Nov 2, 2015 at 1:21 PM, Randall Stewart wrote: > Author: rrs > Date: Mon Nov 2 21:21:00 2015 > New Revision: 290276 > URL: https://svnweb.freebsd.org/changeset/base/290276 > > Log: > Fix three flowtable bugs, a) one lookup issue, b) a two cleaner issue. > This commit message is not helpful, but the review is; it seems like the summary there might have been better for the commit message than naming the number of bugs. Should we assume the three hunks each fix a bug, or what? What if there were four hunks, or two? That kind of ambiguity and obscurity is especially confusing as time passes.