From owner-freebsd-stable@FreeBSD.ORG  Fri Mar  5 00:02:04 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D06E106566B;
	Fri,  5 Mar 2010 00:02:03 +0000 (UTC)
	(envelope-from rmacklem@uoguelph.ca)
Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca
	[131.104.91.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 820FB8FC0C;
	Fri,  5 Mar 2010 00:02:02 +0000 (UTC)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AvsEAAXZj0uDaFvJ/2dsb2JhbACbRXO3SoR8BIMXiyA
X-IronPort-AV: E=Sophos;i="4.49,583,1262581200"; d="scan'208";a="67841886"
Received: from ganges.cs.uoguelph.ca ([131.104.91.201])
	by esa-annu-pri.mail.uoguelph.ca with ESMTP; 04 Mar 2010 19:02:01 -0500
Received: from localhost (localhost.localdomain [127.0.0.1])
	by ganges.cs.uoguelph.ca (Postfix) with ESMTP id 7E3E9FB8027;
	Thu,  4 Mar 2010 19:02:01 -0500 (EST)
X-Virus-Scanned: amavisd-new at ganges.cs.uoguelph.ca
Received: from ganges.cs.uoguelph.ca ([127.0.0.1])
	by localhost (ganges.cs.uoguelph.ca [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id lwJGdca4mjRw; Thu,  4 Mar 2010 19:02:00 -0500 (EST)
Received: from muncher.cs.uoguelph.ca (muncher.cs.uoguelph.ca [131.104.91.102])
	by ganges.cs.uoguelph.ca (Postfix) with ESMTP id 97B06FB801F;
	Thu,  4 Mar 2010 19:02:00 -0500 (EST)
Received: from localhost (rmacklem@localhost)
	by muncher.cs.uoguelph.ca (8.11.7p3+Sun/8.11.6) with ESMTP id
	o250EFs10576; Thu, 4 Mar 2010 19:14:15 -0500 (EST)
X-Authentication-Warning: muncher.cs.uoguelph.ca: rmacklem owned process doing
	-bs
Date: Thu, 4 Mar 2010 19:14:15 -0500 (EST)
From: Rick Macklem <rmacklem@uoguelph.ca>
X-X-Sender: rmacklem@muncher.cs.uoguelph.ca
To: Daniel Braniss <danny@cs.huji.ac.il>
In-Reply-To: <E1NmPHy-0009jy-Dj@kabab.cs.huji.ac.il>
Message-ID: <Pine.GSO.4.63.1003041910550.9956@muncher.cs.uoguelph.ca>
References: <20100226174021.8feadad9.gerrit@pmp.uni-hannover.de> 
	<E1Nl6VA-000557-D9@kabab.cs.huji.ac.il>
	<20100226224320.8c4259bf.gerrit@pmp.uni-hannover.de>
	<4B884757.9040001@digiware.nl>
	<20100227080220.ac6a2e4d.gerrit@pmp.uni-hannover.de>
	<4B892918.4080701@digiware.nl>
	<20100227202105.f31cbef7.gerrit@pmp.uni-hannover.de>
	<20100227193819.GA60576@icarus.home.lan>
	<BD8AC9F6-DF96-41F9-8E92-48A4E5606DC7@anduin.net>
	<4B89943C.70704@digiware.nl> <20100227220310.GA65110@icarus.home.lan>
	<Pine.GSO.4.63.1003011703100.26054@muncher.cs.uoguelph.ca>
	<E1NmPHy-0009jy-Dj@kabab.cs.huji.ac.il>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: stable@freebsd.org, freebsd-fs@freebsd.org,
	Willem Jan Withagen <wjw@digiware.nl>,
	=?utf-8?B?R2Vycml0IEvDvGhu?= <gerrit@pmp.uni-hannover.de>,
	=?utf-8?B?RWlyaWsgw5h2ZXJieQ==?= <ltning@anduin.net>,
	rwatson@freebsd.org, Jeremy Chadwick <freebsd@jdc.parodius.com>
Subject: Re: mbuf leakage with nfs/zfs? 
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2010 00:02:04 -0000



On Tue, 2 Mar 2010, Daniel Braniss wrote:

>
> just keep sending insights/pointers and enjoy life
>


You could try this patch for sys/rpc/replay.c. Completely untested and
just typed into email (so don't give it to "patch", just edit the file).

- try adding these 2 lines just before the end of replay_setreply() in
   sys/rpc/replay.c:

-	}
+	} else if (m)
+		m_freem(m);
 	mtx_unlock(&rc->rc_lock);
}

It's the only place I can see in replay.c that might leak, rick