From owner-svn-src-head@freebsd.org Sun Jan 14 04:31:48 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5BE7E79037; Sun, 14 Jan 2018 04:31:48 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A05BF6A2F2; Sun, 14 Jan 2018 04:31:48 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w0E4VeHx001256 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 13 Jan 2018 20:31:41 -0800 Subject: Re: svn commit: r327950 - in head/sys/powerpc: aim include powerpc ps3 From: Nathan Whitehorn To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801132314.w0DNEra5002692@repo.freebsd.org> <20180113232441.GV1684@kib.kiev.ua> <010d0153-8931-a3c2-db21-dfcbaf848fc0@freebsd.org> Message-ID: Date: Sat, 13 Jan 2018 20:31:40 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <010d0153-8931-a3c2-db21-dfcbaf848fc0@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVa++FdYQMLOkTwAkeevxbwInjy1K2di38sKsN+vxQ/PW6iH07cfFCNYnlLj+5gegqJJ/VuCE26RcUSDbPtgmeaGwX+o10wPPl0= X-Sonic-ID: C;CP0N0eP45xGZtOBQ9eIpJw== M;zDF00eP45xGZtOBQ9eIpJw== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 04:31:48 -0000 On 01/13/18 15:28, Nathan Whitehorn wrote: > > > On 01/13/18 15:24, Konstantin Belousov wrote: >> On Sat, Jan 13, 2018 at 11:14:53PM +0000, Nathan Whitehorn wrote: >>> +/* >>> + * We (usually) have a direct map of all physical memory. All >>> + * uses of this macro must be gated by a check on hw_direct_map! >>> + * The location of the direct map may not be 1:1 in future, so use >>> + * of the macro is recommended; it may also grow an assert that >>> hw_direct_map >>> + * is set. >>> + */ >>> +#define PHYS_TO_DMAP(x) x >>> +#define DMAP_TO_PHYS(x) x >> Take a look at the sys/vm/vm_page.c:vm_page_free_prep() function. >> > > I think the checks in there should work as designed, unless I'm > missing something. Am I? > -Nathan > Actually, wait, this is broken if hw_direct_map is not set. I can do an #ifdef __powerpc__ hack, but do you have opinions for a better MI flag for "yes, the macro is defined but, no, the direct map may not be available"? -Nathan