From owner-svn-src-all@freebsd.org Fri Aug 17 14:53:50 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EF3A10714B7 for ; Fri, 17 Aug 2018 14:53:50 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2F9AB817E9 for ; Fri, 17 Aug 2018 14:53:50 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 52b94285-a22d-11e8-aff6-0b9b8210da61 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 52b94285-a22d-11e8-aff6-0b9b8210da61; Fri, 17 Aug 2018 14:53:39 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w7HErbHd080560; Fri, 17 Aug 2018 08:53:37 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1534517617.27158.11.camel@freebsd.org> Subject: Re: svn commit: r337944 - head/sys/arm/conf From: Ian Lepore To: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 17 Aug 2018 08:53:37 -0600 In-Reply-To: <201808170104.w7H142P8048034@repo.freebsd.org> References: <201808170104.w7H142P8048034@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 14:53:50 -0000 On Fri, 2018-08-17 at 01:04 +0000, Conrad Meyer wrote: > Author: cem > Date: Fri Aug 17 01:04:02 2018 > New Revision: 337944 > URL: https://svnweb.freebsd.org/changeset/base/337944 > > Log: >   arm: Define crypto option on platforms that include IPsec >    >   Missed in r337940. >    >   (It's not like there are any crypto files IPsec doesn't pull in, so it is >   unclear what not defining the crypto option was supposed to achieve.) >    >   Reported by: np@ > > Modified: >   head/sys/arm/conf/std.armv6 >   head/sys/arm/conf/std.armv7 > > Modified: head/sys/arm/conf/std.armv6 > ============================================================================== > --- head/sys/arm/conf/std.armv6 Fri Aug 17 01:03:23 2018 (r337943) > +++ head/sys/arm/conf/std.armv6 Fri Aug 17 01:04:02 2018 (r337944) > @@ -9,6 +9,7 @@ options  VIMAGE # Subsystem virtualization, e.g. VNE >  options  INET # InterNETworking >  options  INET6 # IPv6 communications protocols >  options  TCP_HHOOK # hhook(9) framework for TCP > +device crypto # IPSec && !crypto is nonsensical >  options  IPSEC # IP (v4/v6) security >  options  SCTP # Stream Control Transmission Protocol >  options  FFS # Berkeley Fast Filesystem > > Modified: head/sys/arm/conf/std.armv7 > ============================================================================== > --- head/sys/arm/conf/std.armv7 Fri Aug 17 01:03:23 2018 (r337943) > +++ head/sys/arm/conf/std.armv7 Fri Aug 17 01:04:02 2018 (r337944) > @@ -9,6 +9,7 @@ options  VIMAGE # Subsystem virtualization, e.g. VNE >  options  INET # InterNETworking >  options  INET6 # IPv6 communications protocols >  options  TCP_HHOOK # hhook(9) framework for TCP > +device crypto # IPSec && !crypto is nonsensical >  options  IPSEC # IP (v4/v6) security >  options  SCTP # Stream Control Transmission Protocol >  options  FFS # Berkeley Fast Filesystem > What problem were you trying to solve with this change? Aside from putting a device statement into a file that, by design, only contains options, and besides adding it with a snarky comment rather than the canononical comment associated with that device from sys/conf/NOTES, I can't see offhand how this changes anything. Virtually everything that is dependent on the crypto device is actually specified as crypto | ipsec | ipsec_support, which seems like the correct way to implement "option IPSEC implies device crypto". -- Ian