From nobody Tue Mar 10 10:55:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fVW4k0rH1z6VRdk for ; Tue, 10 Mar 2026 10:55:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fVW4j6rNqz44MB for ; Tue, 10 Mar 2026 10:55:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773140134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QjTy4+SE21t7hi6B5AGr9a0dVMLnv/z81Um3qtrdxo4=; b=d23u0HOIhYSgLX8fRSk3pol0grv2s7BZ68jrMeER8TjbzbQsstTW5aDkz4mVUjwH8W59dp eGLtblZOqi96VX1WvCGsUHsKvwd9QE3ixPzZF98rOnIp4bcQDPo7C26R3a+g/UwVz9DQZD Vwezzc9WsEVTYz1nisXkQhW4/c134ua3zWOjfNpvSI0dUFSN9yfheqKqB78U1lTn0qk+mu z6Itd1DKMuVvsEET6Zq31snQb9ebe9BK7ZFMOJnHMHXidhqlZqSwr8XtxypsAtkviDHRZd vBo6PQ9CTKNsBH/BH2SxqzVUagBRa6mEwroiAfyfshaAizOgmZvFMWvt/apEmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773140134; a=rsa-sha256; cv=none; b=GMEmU7DD9rIZ4o81hKDOWy1xTWKuPjQ8e/IvyA0n2ZYFWKREnOqRc3cz5PrfI/219xGzOo 4nsOQupknTQ4CUVeHYUCHgmCGOG1kQLwSNmOexp2TLMAN4UMfQfwIJxL0ONbM2RVSzLIiL WRAsg1ThfUcGMK6QVLkrAzy5J0wJRLZQXs9s2Sq74gl1J9gOoPIvImCPqDiymCccKTOnh8 VM57et26WZQ2fVhq09HlEwcXIjuunmGmC02ibIdLZQajPe9oLJ8D/r12vIjuvoDWuBJnQ0 NaJeRIYQyavUkqqV19vZQIS3lUyPTGBdjpC86JkHU40Z11SQFHDqvppWK1PAOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773140134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QjTy4+SE21t7hi6B5AGr9a0dVMLnv/z81Um3qtrdxo4=; b=BzlNW8a7bHt74vTU+0CUa0qfKpdcdoqKy6YC2QGYxqHItmGIFtfK02i6fo+hkGeVOrbW/w aQcKHrXAlqN8A+pm7aAHdBLBNrdf+6gWHQR7j8RB/Zo3co62vYUZxRZobNbQucdI5rxQ9R mTnD9xTvvjZSjiMS1mZ3pLhf1jzMyh79UTzpSrAfv6zW4Tc1lsxbWONEBmgnEgFB+wpDBA PnWQc3DJEJyamN67qBZPDgIAsy7SoH8Mg1sbtg1fNjCBPhc7803u0DO1a8o3d6iXuSwRLE 0wnc2hujQu3lQ8HpS1xv6x+wh4PaWVMoWgZ67DDVz3VP1YcQC52uvrMPpRNsUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fVW4j68kvz17lr for ; Tue, 10 Mar 2026 10:55:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46547 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Mar 2026 10:55:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: a2b601343bf9 - main - virtual_oss: Combine -d, -l and -L option getopt code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a2b601343bf9261c4ada51e4d4c30c5b9320bb2b Auto-Submitted: auto-generated Date: Tue, 10 Mar 2026 10:55:28 +0000 Message-Id: <69aff8a0.46547.1503cad9@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=a2b601343bf9261c4ada51e4d4c30c5b9320bb2b commit a2b601343bf9261c4ada51e4d4c30c5b9320bb2b Author: Christos Margiolis AuthorDate: 2026-03-10 10:55:21 +0000 Commit: Christos Margiolis CommitDate: 2026-03-10 10:55:21 +0000 virtual_oss: Combine -d, -l and -L option getopt code Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55671 --- usr.sbin/virtual_oss/virtual_oss/main.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/usr.sbin/virtual_oss/virtual_oss/main.c b/usr.sbin/virtual_oss/virtual_oss/main.c index 6c5ba8112c8b..6a56adbc6075 100644 --- a/usr.sbin/virtual_oss/virtual_oss/main.c +++ b/usr.sbin/virtual_oss/virtual_oss/main.c @@ -2228,24 +2228,6 @@ parse_options(int narg, char **pparg, int is_main) strncpy(profile.wav_name, optarg, sizeof(profile.wav_name)); break; case 'd': - if (strlen(optarg) > VMAX_STRING - 1) - return ("Device name too long"); - strncpy(profile.oss_name, optarg, sizeof(profile.oss_name)); - - if (profile.bits == 0 || voss_dsp_sample_rate == 0 || - profile.channels == 0 || voss_dsp_samples == 0) - return ("Missing -b, -r, -c or -s parameters"); - - val = (voss_dsp_samples * - profile.bits * profile.channels) / 8; - if (val <= 0 || val >= (1024 * 1024)) - return ("-s option value is too big"); - - ptr = dup_profile(&profile, opt_amp, opt_pol, - opt_mute[0], opt_mute[1], 0, 1); - if (ptr != NULL) - return (ptr); - break; case 'L': case 'l': if (strlen(optarg) > VMAX_STRING - 1) @@ -2254,7 +2236,7 @@ parse_options(int narg, char **pparg, int is_main) if (profile.bits == 0 || voss_dsp_sample_rate == 0 || profile.channels == 0 || voss_dsp_samples == 0) - return ("Missing -b, -r, -r or -s parameters"); + return ("Missing -b, -r, -c or -s parameters"); val = (voss_dsp_samples * profile.bits * profile.channels) / 8; @@ -2262,7 +2244,7 @@ parse_options(int narg, char **pparg, int is_main) return ("-s option value is too big"); ptr = dup_profile(&profile, opt_amp, opt_pol, - opt_mute[0], opt_mute[1], c == 'L', 0); + opt_mute[0], opt_mute[1], c == 'L', c == 'd'); if (ptr != NULL) return (ptr); break;