From owner-dev-commits-src-main@freebsd.org Tue Jul 6 19:18:32 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15CA9666409; Tue, 6 Jul 2021 19:18:32 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GKC5M71kBz4j48; Tue, 6 Jul 2021 19:18:31 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id BF9A5AB35; Tue, 6 Jul 2021 19:18:31 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 3BC2A45F2C; Tue, 6 Jul 2021 21:18:29 +0200 (CEST) From: "Kristof Provost" To: "Alexander Motin" Cc: "Ram Kishore Vegesna" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 29e2dbd42c3e - main - ocs_fc: Add gendump and dump_to_host ioctl command support. Date: Tue, 06 Jul 2021 21:18:28 +0200 X-Mailer: MailMate (1.13.2r5673) Message-ID: <0BD4E409-AD73-45F8-80B4-99E6FAC7BFE6@FreeBSD.org> In-Reply-To: <2b8685de-e94b-9413-b4fd-43526c7903d3@gmail.com> References: <202107061548.166Fm2ol078877@gitrepo.freebsd.org> <2b8685de-e94b-9413-b4fd-43526c7903d3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 19:18:32 -0000 On 6 Jul 2021, at 21:04, Alexander Motin wrote: > On 06.07.2021 14:55, Kristof Provost wrote: >> On 6 Jul 2021, at 17:48, Ram Kishore Vegesna wrote: >> The branch main has been updated by ram: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D29e2dbd42c3e2e10e606b341= 4f4d0c53021d4e86 >> >> commit 29e2dbd42c3e2e10e606b3414f4d0c53021d4e86 >> Author: Ram Kishore Vegesna >> AuthorDate: 2021-06-24 07:05:00 +0000 >> Commit: Ram Kishore Vegesna >> CommitDate: 2021-07-06 15:38:11 +0000 >> >> ocs_fc: Add gendump and dump_to_host ioctl command support. >> >> Support to generate firmware dump. >> >> Approved by: mav(mentor) >> --- >> sys/dev/ocs_fc/ocs_gendump.c | 388 >> +++++++++++++++++++++++++++++++++++++++++++ >> sys/dev/ocs_fc/ocs_gendump.h | 42 +++++ >> sys/dev/ocs_fc/ocs_ioctl.c | 13 +- >> sys/dev/ocs_fc/ocs_ioctl.h | 3 + >> sys/dev/ocs_fc/ocs_mgmt.c | 152 ++--------------- >> sys/dev/ocs_fc/ocs_os.c | 3 +- >> sys/dev/ocs_fc/ocs_os.h | 3 +- >> sys/modules/ocs_fc/Makefile | 3 +- >> 8 files changed, 449 insertions(+), 158 deletions(-) >> >> I=E2=80=99m seeing this build failure (amd64, GENERIC kernel): >> >> |ld: error: undefined symbol: ocs_gen_dump >>> referenced by >> ocs_mgmt.c:485 (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:485) >>> >> ocs_mgmt.o:(ocs_mgmt_exec) ld: error: undefined symbol: = >> ocs_dump_to_host >>>>> referenced by ocs_mgmt.c:489 >> (/usr/src/sys/dev/ocs_fc/ocs_mgmt.c:489) >>> = >> ocs_mgmt.o:(ocs_mgmt_exec) >> *** [kernel.full] Error code 1 | >> >> Does that ring any bells? > > d0732fa81963 should fix it. Sorry for breakage. > That works. Thanks for the quick fix. =E2=80=94 Kristof