From owner-freebsd-virtualization@freebsd.org Fri Nov 6 14:06:51 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 34C4A2EFB0A for ; Fri, 6 Nov 2020 14:06:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CSMdR0p3Xz3pvw for ; Fri, 6 Nov 2020 14:06:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1B4D82EF7F3; Fri, 6 Nov 2020 14:06:51 +0000 (UTC) Delivered-To: virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B15E2EFA0F for ; Fri, 6 Nov 2020 14:06:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSMdR0BD8z3q86 for ; Fri, 6 Nov 2020 14:06:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E99A125EDE for ; Fri, 6 Nov 2020 14:06:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0A6E6ow0085953 for ; Fri, 6 Nov 2020 14:06:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0A6E6oU8085952 for virtualization@FreeBSD.org; Fri, 6 Nov 2020 14:06:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 250795] support RFB 3.3 for VNC client interoperability Date: Fri, 06 Nov 2020 14:06:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: marko@apache.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 14:06:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250795 marko@apache.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #219296|0 |1 is obsolete| | CC| |marko@apache.org --- Comment #6 from marko@apache.org --- Created attachment 219393 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D219393&action= =3Dedit svn diff output of the relevant changes; ver2 Here's an updated version of the patch, which includes additional performan= ce fixes. I incorporated Henrik's changes from the pointed diff; the most important performance improvement from there was the fact that the server would not s= end an update until client requests one. I also reduced the amount of memory allocated for CRC buffers. It was compu= ted slightly incorrectly, but ended up allocating 32 times too much memory. Behaviour changes are now that a) support RFB protocol versions 3.3 and 3.7= for authentication, b) don't send first screen until client asks for it c) don't send updates (at all) unless client has asked for it AND we have data to se= nd. I've tested this against tightVNC, realVNC, apple's screen sharing, tigerVN= C, krdc and vinagre. --=20 You are receiving this mail because: You are the assignee for the bug.=