From owner-svn-src-all@freebsd.org Mon Nov 18 20:48:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0CE141C94A0; Mon, 18 Nov 2019 20:48:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47H1JV6dZ7z4WCv; Mon, 18 Nov 2019 20:48:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x832.google.com with SMTP id p20so21856956qtq.5; Mon, 18 Nov 2019 12:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MeHJxYkhxKqlFC13dNJXs+nX4XUgdKNTEUnmCuW7HGo=; b=tZPAofOO+eubye+AcYxfJbNwNLhzVskai1yX0UyrnP1Axj5fBYcxylrOk8iKSJ9ZXQ GyhZlRoyU8k3mQJiyADgDEj+LXrcrEunJ5aLcbIW48PvA0Cr+6DpB5aEygZKWPjNzyw0 2LxpzazX00qruC+0BTfWLJdN65HMl+7RFQv3YzpD5OgMZXtvHQP7t3MczAFitwtdWEui niiQsN1pcOSELzyN0ZxZbN2Yq1GEwMJZMBrZsWiD59yMS1PXva2NwggoeXkTWUlN4JAY Ma0NOfej+cUnSFPfAi2inxCCgefEWdcJjrCnUoaFTsX/GFyQFP2ZRkri8f9IXqZxBfK4 WHOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=MeHJxYkhxKqlFC13dNJXs+nX4XUgdKNTEUnmCuW7HGo=; b=WRcy+Diw/hYzsukYdS5Mfb85EypxpbQrP7vvkkfrgC9vxzwG62f1yZONY89qgIzKhl SqfIP5rw6TMi+0B60vuO2aouHPttY5EeLkGm+9M9BPyXlWIJwpxFW23Ex0KCYT5WtqhT f2U9hQ8o/gFmvxMUCYAoPbCuK18ofzjiw8Nz3bwMnJTkCS4WcWDUPrAVLyD/hFk98Uof yDxGiKq5IzqdV4oMJljH0CdrIPQgzz5L2nm71QRC7U2WeSBpk6Zv1twr4/Eszozm72Ut 4PA0ghgXGiGwiMsC3YxURbuZo/TRMo2RXDZuLOaUqoa2EeKV7D28pl4ciKLlWH/NXBcj QMFg== X-Gm-Message-State: APjAAAWAnCWNU7abgubE49HWbbG40UyoogbTPI9oU1HPlhrWMM+io0Fy O+Yc0paBhrSM+kDKNTfon0Q6U/Nokhk= X-Google-Smtp-Source: APXvYqwYQFrwEOpn/0nFNLEOZ4aEIFWZA1Z8RLqyEt8+Ug4Q/rdMkj1Ery1GkY6HSgKvf5r613Hj1g== X-Received: by 2002:ac8:2ff3:: with SMTP id m48mr30414043qta.127.1574110120096; Mon, 18 Nov 2019 12:48:40 -0800 (PST) Received: from raichu (toroon0560w-lp130-05-69-158-183-252.dsl.bell.ca. [69.158.183.252]) by smtp.gmail.com with ESMTPSA id m25sm11660173qtc.0.2019.11.18.12.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 12:48:39 -0800 (PST) Sender: Mark Johnston Date: Mon, 18 Nov 2019 15:48:36 -0500 From: Mark Johnston To: Alexey Dokuchaev Cc: Alan Somers , svn-src-head , svn-src-all , src-committers Subject: Re: svn commit: r354824 - head/lib/geom/part Message-ID: <20191118204836.GB43295@raichu> References: <201911181905.xAIJ5q6A068355@repo.freebsd.org> <20191118194501.GA43295@raichu> <20191118203529.GA64688@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191118203529.GA64688@FreeBSD.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47H1JV6dZ7z4WCv X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.80 / 15.00]; NEURAL_HAM_MEDIUM(-0.81)[-0.807,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-0.99)[-0.993,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2019 20:48:43 -0000 On Mon, Nov 18, 2019 at 08:35:30PM +0000, Alexey Dokuchaev wrote: > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston wrote: > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > > wrote: > > > > > > > > > Author: markj > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > New Revision: 354824 > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > Log: > > > > > Fix grammar in gpart.8. > > > > > > > > > > PR: 241973 > > > > > MFC after: 3 days > > > > > > > > > > Modified: > > > > > head/lib/geom/part/gpart.8 > > > > > > > > Don't forget to bump the .Dd date. > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > Isn't that a content change? I thought anything displayed to the user > > counts as a content change? > > I presume that "content" means more like semantic, functional changes > that affect some particular meaning. Grammar fixes are just, well, > grammar fixes and thus do not warrant .Dd bump. Indeed, this was always my understanding as well. I can't find a concrete definition anywhere. I don't understand why it would be useful as a user to see the date of the last "content change" if such changes might consist only of a small formatting change or typo fix.