From owner-cvs-src-old@FreeBSD.ORG Fri May 15 19:23:16 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94DB61065677 for ; Fri, 15 May 2009 19:23:16 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 832A48FC13 for ; Fri, 15 May 2009 19:23:16 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n4FJNGK1057535 for ; Fri, 15 May 2009 19:23:16 GMT (envelope-from kib@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n4FJNGs4057534 for cvs-src-old@freebsd.org; Fri, 15 May 2009 19:23:16 GMT (envelope-from kib@repoman.freebsd.org) Message-Id: <200905151923.n4FJNGs4057534@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to kib@repoman.freebsd.org using -f From: Konstantin Belousov Date: Fri, 15 May 2009 19:23:05 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2009 19:23:16 -0000 kib 2009-05-15 19:23:05 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c Log: SVN rev 192151 on 2009-05-15 19:23:05Z by kib Devfs replaces file ops vector with devfs-specific one in devfs_open(), before the struct file is fully initialized in vn_open(), in particular, fp->f_vnode is NULL. Other thread calling file operation before f_vnode is set results in NULL pointer dereference in devvn_refthread(). Initialize f_vnode before calling d_fdopen() cdevsw method, that might set file ops too. Reported and tested by: Chris Timmons (RELENG_7 version) MFC after: 3 days Revision Changes Path 1.178 +3 -1 src/sys/fs/devfs/devfs_vnops.c