From owner-aic7xxx Thu Aug 6 13:47:16 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA26836 for aic7xxx-outgoing; Thu, 6 Aug 1998 13:47:16 -0700 (PDT) (envelope-from owner-aic7xxx@FreeBSD.ORG) Received: from dledford.dialnet.net (dledford.dialnet.net [206.65.249.116]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA26647 for ; Thu, 6 Aug 1998 13:46:29 -0700 (PDT) (envelope-from dledford@dialnet.net) Received: from dialnet.net (localhost [127.0.0.1]) by dledford.dialnet.net (8.8.5/8.8.4) with ESMTP id PAA04040; Thu, 6 Aug 1998 15:44:20 -0500 Message-ID: <35CA15A4.F7D90461@dialnet.net> Date: Thu, 06 Aug 1998 15:44:20 -0500 From: Doug Ledford X-Mailer: Mozilla 4.05 [en] (X11; I; Linux 2.1.109 i686) MIME-Version: 1.0 To: System Administrator CC: aic7xxx@FreeBSD.ORG Subject: Re: applying patches References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-aic7xxx@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org System Administrator wrote: > > can someone tell me where i should be applying the driver patches in the > kernel tree. i try from the directory just above my linux source and it > patches fine except for 2 files "aic7xxx_seq.c" and "bsd_q.h" that it > leaves in the current directory. which then i have to copy manually to > linux/drivers/scsi/aic7xxx > > i tried from the linux, scsi, and aic7xxx directory and all ask me for > a file to patch. > > i'm patching with: patch < patchfile Arggg.....quoting from ftp.dialnet.net:/pub/linux/aic7xxx/7890-Status: -- Wed, July 8, 15:39 OK..I've had one instance of this so far, and this is somewhat of a religious issue for me, so I'm adding a quick note here. These pre-patches and the real patches (when done) are adding new files to the linux source code tree. There is a well known problem with the patch program and new files when you don't use the -p option to the patch program. So here's the recommendation from a kernel hacker on the correct, painless, religiously tolerable :) method of using patch: 1. Always cd *into* the kernel directory you wish to patch. This way, if you didn't make your kernel directory named linux, or someone's patch wasn't made against files in a directory called linux, there won't be a problem because you are in the directory you want to be in. 2. While you are there, use the patch program with the switches -p1 and -E. The -p1 tells the patch program you went on into the 1st directory and that should be stripped from the filenames in the patch, and the -E tells patch to remove those files that are totally empty when the patch is done. There, follow those two rules, and patching will go very smooth in the future for you :) -- Doug Ledford Opinions expressed are my own, but they should be everybody's. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe aic7xxx" in the body of the message