From owner-svn-src-all@freebsd.org Fri Aug 28 16:26:04 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AD7B13B673C; Fri, 28 Aug 2020 16:26:04 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BdQ2M02hjz3YvQ; Fri, 28 Aug 2020 16:26:02 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id 07SGPwED018368; Fri, 28 Aug 2020 18:25:58 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id F0DE5F9E; Fri, 28 Aug 2020 18:25:57 +0200 (CEST) Subject: Re: svn commit: r364863 - head To: Ryan Moeller , Kyle Evans , svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <202008271326.07RDQbGd016044@repo.freebsd.org> <1e71689e-5dca-f5cc-bc3a-177b45621431@FreeBSD.org> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <1003ad68-5339-789c-1451-f26ff2a31606@omnilan.de> Date: Fri, 28 Aug 2020 18:25:56 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1e71689e-5dca-f5cc-bc3a-177b45621431@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: ACL 136 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Fri, 28 Aug 2020 18:25:58 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: 4BdQ2M02hjz3YvQ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2a00:e10:2800::a130 as permitted sender) smtp.mailfrom=freebsd@omnilan.de X-Spamd-Result: default: False [-2.19 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+mx]; DMARC_NA(0.00)[omnilan.de]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.92)[-0.920]; NEURAL_HAM_LONG(-0.97)[-0.966]; NEURAL_HAM_SHORT(-0.00)[-0.005]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:61157, ipnet:2a00:e10:2800::/38, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-src-head,svn-src-all] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 16:26:04 -0000 Am 28.08.2020 um 17:43 schrieb Ryan Moeller: … >> ld: error: undefined symbol: zfs_zstd_decompress_level >> >>> referenced by zio_compress.c >> >>>               zio_compress.o:(zio_compress_table) >> *** Error code 1 >> >> According to src/sys/amd64/conf/NOTES, "options ZFS" should still be >> supported. >> Unfortunately I have no adhoc idea how to fix. Anybody else? > > > You need options ZSTDIO, too. NOTES needs to be updated. Thanks a lot! May I suggest the following change: Index: sys/contrib/openzfs/man/man8/zfsprops.8 =================================================================== --- sys/contrib/openzfs/man/man8/zfsprops.8 (Revision 364900) +++ sys/contrib/openzfs/man/man8/zfsprops.8 (Arbeitskopie) @@ -1049,8 +1049,9 @@ dataset creation time and it cannot be changed afterwards. .Pp For more details and caveats about encryption see the -.Sy Encryption -section. +.Em Encryption +section of +.Xr zfs-load-key 8 . .It Sy keyformat Ns = Ns Sy raw Ns | Ns Sy hex Ns | Ns Sy passphrase Controls what format the user's encryption key will be provided as. This property is only set when the dataset is encrypted. Curious about the new OpenZFS bells and whistles, I promptly struggeld over finding "the Encryption section". Some lines above, the man page already mentiones explicitly zfs-load-key.8 while referencing the Encryption section, so I just copied the macros used there - not much clue about man here… Thanks, -harry