From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct 19 09:00:15 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AE71F1065679
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 19 Oct 2009 09:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 78EBD8FC31
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 19 Oct 2009 09:00:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9J90DGA050793
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 19 Oct 2009 09:00:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9J90Dwt050792;
	Mon, 19 Oct 2009 09:00:13 GMT (envelope-from gnats)
Resent-Date: Mon, 19 Oct 2009 09:00:13 GMT
Resent-Message-Id: <200910190900.n9J90Dwt050792@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Xavier Heiny <xavier.heiny@netasq.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5AEB3106568F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 19 Oct 2009 08:56:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4ADBE8FC17
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 19 Oct 2009 08:56:41 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9J8ueLw071207
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Oct 2009 08:56:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n9J8ueRY071206;
	Mon, 19 Oct 2009 08:56:40 GMT (envelope-from nobody)
Message-Id: <200910190856.n9J8ueRY071206@www.freebsd.org>
Date: Mon, 19 Oct 2009 08:56:40 GMT
From: Xavier Heiny <xavier.heiny@netasq.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: bin/139751: [patch] fetch/libfetch : NO_PROXY=localhost seems to
	not work properly.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2009 09:00:15 -0000


>Number:         139751
>Category:       bin
>Synopsis:       [patch] fetch/libfetch : NO_PROXY=localhost seems to not work properly.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 19 09:00:13 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Xavier Heiny
>Release:        7.0
>Organization:
Netasq
>Environment:
>Description:
fetch/libfetch : NO_PROXY=localhost seems to not work properly.

To make it work, setting NO_PROXY=ocalhost instead of NO_PROXY=localhost is mandatory.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- lib/libfetch/common.c	Wed Feb 16 13:46:46 2005
+++ lib/libfetch/common.c	Tue Sep 17 16:37:23 2009
@@ -772,7 +772,7 @@
 				break;
 
 		d_len = q - p;
-		if (d_len > 0 && h_len > d_len &&
+		if (d_len > 0 && h_len >= d_len &&
 		    strncasecmp(host + h_len - d_len,
 			p, d_len) == 0) {
 			/* domain name matches */


>Release-Note:
>Audit-Trail:
>Unformatted: