From owner-svn-src-all@freebsd.org Sat Dec 15 16:58:36 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD3AB1325E7A for ; Sat, 15 Dec 2018 16:58:36 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1CF2980021 for ; Sat, 15 Dec 2018 16:58:36 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1544893107; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=lRQsFsNTCqx7zYPHrQS9KTR/zMgb6B/RXii9J/ddxtJ/bKW5Dor1A0jNplphRyg3ja6eJRKW18ajZ urgAGjWxFenvNqvF7ixQaHoInHC6rZL0cczAAuklRJjg9W2DAH5YoeC19ms496M//xlbjLbqVOBFma HQmdubfaqJQWjI7X6Fhsc+olVC8mgsRBcfvq6vB8zsx8ZWs2RIXybYgj+pMacDrVxPLxC7vqEOiVBR EBWW0VwaQNPNjYJY5nICr355dyUApAjzB880y7plK+k2Qug32iE+gBawIVmeLk4Kt8XWpJG/wDdf0Y TIUrHgAx9YT9g3DQ/3mjQ36vcrOaggw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=JRNAgPYa1jyxeU3BTKBoxj0bNn5b19XtUvRZ1MMTExY=; b=Vid1YeyystpPfTDIVkLDHOBVGuW2O8k9xu+pt/O5xjseOzWkYab22u/8SWl05D+YxfrhYzav+w80o b/F1P1tc1MpV48fXuTQRQpPDozSlKHnI81870ifC9bBF2aWE2tGtl5hiWArtTYgu9KUyEFXKf1GzLr tElJN+aquoT9OcBKa//Pn3Nvp28/T4EIg6ejBlLOvT/+K1pJn0Ph8UQNGrLGD63RkVOjY5NSmVqUSs GgJXkp8q3fpihq7awRK9owedj7423Qen0mR33agI6w+lzvjvBVqzbPBSFk/d/wm8Qh+/aokpegefZG kp8mSn6M8Vz7Z/Ugl9N1/0nWHqugvdw== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=JRNAgPYa1jyxeU3BTKBoxj0bNn5b19XtUvRZ1MMTExY=; b=lgQcbIcebrgx42bfO+GBHDgrLjbv04Id+uO/k2aRoUuaevOCyRkThep07ntOh99bY/yL9E10Ag46u fO+ukoEkHt4HLUJ2uTX8ulOF3CTdEuXzQOEJDB0/8e8VNPbqhf/vRgK1ERUUFQrjULuTbwzVTsQN+L yvWOsBaOEtpf747TYSigZPAEdI+PwDocELnIBd3/d5MdWtGNNUI/w9GvXiF7zYSiVeGrHyI+eKsOEe 1DrLbaZA9uNkp9rp0Q9NlqRBtOVI0h4OcN8vakv4qzJ2r+WpF06jdrVU2rbdrZ0V55WnI/w6RSTSJL xfo4kC/V/QD9oZlQpl1+eCRhg9P5CMQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: a1940152-008a-11e9-8a28-a1efd8da9a94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id a1940152-008a-11e9-8a28-a1efd8da9a94; Sat, 15 Dec 2018 16:58:24 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id wBFGwM47087200; Sat, 15 Dec 2018 09:58:22 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1544893102.76088.70.camel@freebsd.org> Subject: Re: svn commit: r341794 - stable/11/etc/periodic/weekly From: Ian Lepore To: Eugene Grosbein , Andre Albsmeier Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Date: Sat, 15 Dec 2018 09:58:22 -0700 In-Reply-To: References: <201812101424.wBAEOgbC053582@repo.freebsd.org> <20181215090926.GA33682@bali> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1CF2980021 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2018 16:58:36 -0000 On Sat, 2018-12-15 at 17:55 +0700, Eugene Grosbein wrote: > 15.12.2018 16:09, Andre Albsmeier wrote: > > > > > On Mon, 10-Dec-2018 at 14:24:42 +0000, Eugene Grosbein wrote: > > > > > > Author: eugen > > > Date: Mon Dec 10 14:24:41 2018 > > > New Revision: 341794 > > > URL: https://svnweb.freebsd.org/changeset/base/341794 > > > > > > Log: > > >   MFC r340322-r340324,r340327: periodic/etc/weekly/340.noid > > >    > > >   Prevent periodic/etc/weekly/340.noid from descending into root > > > directories > > >   of jails. Jails have their own user/group databases and this > > > script > > >   can produce multiple false warnings, not to mention significant > > > extra > > >   load in case of large jailed subtrees. Leave this check for > > > jailed > > >   invocations of the same script. > > This gave me: > > > > Check for files with an unknown user or group: > > .: cannot open /usr/share/bsdconfig/common.subr: No such file or > > directory > > > > on systems where bsdconfig is not installed. > This periodic script does not try to access > /usr/share/bsdconfig/common.subr > I think error message comes from another periodic script. > Can you please run it with "sh -x /etc/periodic/weekly/340.noid" to > make sure? > > It uses sysrc, which sources in /usr/share/bsdconfig/common.subr; this is the first reference to sysrc in any periodic script, so it does establish a new dependency, requiring sysrc to be installed on any system that runs periodic scripts. A safer way to extract the root path of all running jails might be something like:   if which -s jls; then       allpaths="$(jls -d path)"       for onepath in ${allpaths}; do            # do whatever with ${onepath} here       done   fi -- Ian