From owner-freebsd-bugs  Thu Aug 12 22: 1:43 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 881F7157E5
	for <freebsd-bugs@FreeBSD.org>; Thu, 12 Aug 1999 22:01:35 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id WAA58083;
	Thu, 12 Aug 1999 22:00:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Date: Thu, 12 Aug 1999 22:00:03 -0700 (PDT)
Message-Id: <199908130500.WAA58083@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: <jkoshy@FreeBSD.org>
Subject: Re: kern/10959: 3.1-STABLE crashes due to a floppy mount problem 
Reply-To: <jkoshy@FreeBSD.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR kern/10959; it has been noted by GNATS.

From: <jkoshy@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: Bruce Evans <bde@zeta.org.au>, phk@FreeBSD.org
Subject: Re: kern/10959: 3.1-STABLE crashes due to a floppy mount problem 
Date: Thu, 12 Aug 1999 21:54:14 -0700 (PDT)

 The following band-aid patch fixes the panic reported in PR kern/10959,
 affecting both 3-STABLE and 4-CURRENT.  It avoids the panic by behaving
 more like the UFS code does.  Could you please review?
 
 I'm open to suggestions for a better fix for the panic.
 
 Thanks,
 Koshy
 <jkoshy@freebsd.org>
 
 Index: sys/msdosfs/msdosfs_vfsops.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/msdosfs/msdosfs_vfsops.c,v
 retrieving revision 1.46
 diff -u -r1.46 msdosfs_vfsops.c
 --- msdosfs_vfsops.c	1999/08/08 18:42:54	1.46
 +++ msdosfs_vfsops.c	1999/08/13 10:14:21
 @@ -779,7 +779,6 @@
  	if (error)
  		return error;
  	pmp = VFSTOMSDOSFS(mp);
 -	pmp->pm_devvp->v_specmountpoint = NULL;
  #ifdef MSDOSFS_DEBUG
  	{
  		struct vnode *vp = pmp->pm_devvp;
 @@ -805,6 +804,9 @@
  	error = VOP_CLOSE(pmp->pm_devvp,
  		    (pmp->pm_flags&MSDOSFSMNT_RONLY) ? FREAD : FREAD | FWRITE,
  		    NOCRED, p);
 +        if (error)
 +		return (error);
 +	pmp->pm_devvp->v_specmountpoint = NULL;
  	vrele(pmp->pm_devvp);
  	free(pmp->pm_inusemap, M_MSDOSFSFAT);
  	free(pmp, M_MSDOSFSMNT);
 
 
 
 
 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message