From owner-cvs-all Mon Jun 11 2: 8:58 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 7CCBA37B403; Mon, 11 Jun 2001 02:08:52 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: (from phk@localhost) by freefall.freebsd.org (8.11.3/8.11.3) id f5B98qM07061; Mon, 11 Jun 2001 02:08:52 -0700 (PDT) (envelope-from phk) Message-Id: <200106110908.f5B98qM07061@freefall.freebsd.org> From: Poul-Henning Kamp Date: Mon, 11 Jun 2001 02:08:52 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern tty_pty.c X-FreeBSD-CVS-Branch: RELENG_4 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG phk 2001/06/11 02:08:52 PDT Modified files: (Branch: RELENG_4) sys/kern tty_pty.c Log: MFC: With the new kernel dev_t conversions done at release 4.X, it becomes possible to trap in ptsstop() in kern/tty_pty.c if the slave side has never been opened during the life of a kernel. What happens is that calls to ttyflush() done from ptyioctl() for the controlling side end up calling ptsstop() [via (*tp->t_stop)(tp, )] which evaluates the following: struct pt_ioctl *pti = tp->t_dev->si_drv1; In order for tp->t_dev to be set, the slave device must first be opened in ttyopen() [kern/tty.c]. It appears that the only problem is calls to (*tp->t_stop)(tp, ), so this could also happen with other ioctls initiated by the controlling side before the slave has been opened. Revision Changes Path 1.74.2.2 +2 -1 src/sys/kern/tty_pty.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message