From owner-cvs-all@FreeBSD.ORG Mon Jul 31 15:38:45 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D452816A4E1 for ; Mon, 31 Jul 2006 15:38:45 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA6A143D62 for ; Mon, 31 Jul 2006 15:38:40 +0000 (GMT) (envelope-from infofarmer@gmail.com) Received: by ug-out-1314.google.com with SMTP id m2so860332uge for ; Mon, 31 Jul 2006 08:38:33 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=A9u63NwbFHl8DWvCWYXbPtoZDrd9XtNAuF/GwrA7qefANZYzuM5+aNWjJATx8GzO56p+hMXZdzyrXmp/zLYHHfzOAE28Pjltyhe11a3Hul2BFTGID7FUAiAnB5Kn9tQocgnM4Iq+vSxd/4678GZgQlwEjZ3kF6TZssDFBnqyL6E= Received: by 10.78.193.19 with SMTP id q19mr567029huf; Mon, 31 Jul 2006 08:38:33 -0700 (PDT) Received: by 10.35.105.10 with HTTP; Mon, 31 Jul 2006 08:38:33 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2006 19:38:33 +0400 From: "Andrew Pantyukhin" Sender: infofarmer@gmail.com To: "Alexander Leidinger" In-Reply-To: <20060731121024.3d6478b4@Magellan.Leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200607302234.k6UMYUuq018943@repoman.freebsd.org> <20060731121024.3d6478b4@Magellan.Leidinger.net> X-Google-Sender-Auth: 48819a44575ef248 Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.linux-rpm.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: infofarmer@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 15:38:45 -0000 On 7/31/06, Alexander Leidinger wrote: > Quoting Andrew Pantyukhin (Sun, 30 Jul 2006 22:34:30 +0000 (UTC)): > > > sat 2006-07-30 22:34:30 UTC > > > > FreeBSD ports repository > > > > Modified files: > > Mk bsd.linux-rpm.mk > > Log: > > - Only set default m_s_subdir if master_sites was undefined > > Would you please describe which problem this commit tries to solve > (perhaps as a forced commit)? Fedora has a rather unique MSS scheme (related to its versioning) and applying the scheme to another MS does not seem very practical. In practice, a more relevant default value might be attempted to be set after bsd.linux-rpm.mk. > I'm not sure if we have some ports which set MS but depend on the auto > assigning of MSS, but I would not be surprised if we have such ports. > Did you check for such ports? Sure. There are 29 USE_LINUX_RPM ports, only three set MS, two of them don't need MSS at all and the third one would rather MSS was not touched by linux-rpm.mk. I'm sorry I committed this without prior discussion, but I tried to make sure the change was not desctructive and as simple as it gets.