From owner-svn-src-all@freebsd.org Mon Mar 11 17:04:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A3A9152664B; Mon, 11 Mar 2019 17:04:12 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-it1-x12c.google.com (mail-it1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 16B927053A; Mon, 11 Mar 2019 17:04:12 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-it1-x12c.google.com with SMTP id m137so8459949ita.0; Mon, 11 Mar 2019 10:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mFhZKJiJXEZYaXfvlCgpXeRcjZZrkb7EBj1Qe7kuur4=; b=ZlxLn8zwvolREQimCIRUIfbUstyJxObJ2TCu2LFzISipaLh5iFiC98hS3V8afIbP8X KGGWqW1o3iLEYQfZ7ipKd3S38RggLXm2KZhdMz/vKbhppBY6TfvGA7wFLrWo9Qgr5iVq EPdPhePcwWHCpIRwU8CYOsqRspTtuAhnnYm1YZS47FPGRhMA4OzheIZO5ST0r4IOrTXy Kt/yMmnn7YY7AgJ1kFHHNET5GeZx6Bw+GIzgVSlNLNzJEGaEeG6rGMrhisDqpa1kHPmg QyG6e5uvPD9PHiLbEOt8ecPINHfSnWD5Lo2IpBoU/tcmDVbYrSc6f/YAt7PJ4lxQmweM +VhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mFhZKJiJXEZYaXfvlCgpXeRcjZZrkb7EBj1Qe7kuur4=; b=ke45jGijmOrfsodWrCNDmZGvLx081MhOhty/0O2SVDF29bhlk+PThJHJoDxPv58a+X 56A0f7C7zWOkWWnceaFMsRvU+nS4cPCoFNz+foka+G3eKxAGjLeHz0vIZgUIXD8u+y/d N4Lt0g8V3FS3xDlWn7a/vcKjhn0OqreWPTrhz8dCCDKtikhP/ksKnN6nrHVnUmk3COM0 q/UEbLwrgnJXMQfut7lFOVQCfboy1qwRg3sngHrVxV9UzSNV7pxNfw/gz4WaAAz/BJ13 eO9Djs189a6L/SoeK4zWay4YOWaoHGaqh0p18QeS/jpQ2HuB16f3g0CquTJmDZ2q7Vl+ QebQ== X-Gm-Message-State: APjAAAX8g7Kqh4gKBgThEPEoR/aqCG8Y4vLOyFmYOFCfN3TQo2v09xt1 O3iNlV6mueWUuo8uoOLWMx4Lq4GIQIU= X-Google-Smtp-Source: APXvYqxgk9MmWem3EgSV3rxPrhjCsOvjfco3tvkzCjnTEbOzr5qsWsIbht/InwFyeHsNfuCEFVcudg== X-Received: by 2002:a02:4f1c:: with SMTP id c28mr18301894jab.112.1552323850790; Mon, 11 Mar 2019 10:04:10 -0700 (PDT) Received: from titan.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id k9sm2472296iob.2.2019.03.11.10.04.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Mar 2019 10:04:10 -0700 (PDT) Date: Mon, 11 Mar 2019 12:04:06 -0500 From: Justin Hibbits To: John Baldwin Cc: Alexey Dokuchaev , Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc Message-ID: <20190311120406.58a21e1e@titan.knownspace> In-Reply-To: <7e2e2cca-ae57-4ab4-6144-54cd196dce70@FreeBSD.org> References: <201903090318.x293IcLc023548@repo.freebsd.org> <20190309085058.GA60945@FreeBSD.org> <20190310171640.31bb9c54@titan.knownspace> <7e2e2cca-ae57-4ab4-6144-54cd196dce70@FreeBSD.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 16B927053A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.987,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 17:04:12 -0000 On Mon, 11 Mar 2019 10:02:00 -0700 John Baldwin wrote: > On 3/10/19 3:16 PM, Justin Hibbits wrote: > > On Sat, 9 Mar 2019 08:50:58 +0000 > > Alexey Dokuchaev wrote: > > > >> On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote: > >>> New Revision: 344960 > >>> URL: https://svnweb.freebsd.org/changeset/base/344960 > >>> > >>> Log: > >>> powerpc: Print trap frame address for fatal traps > >>> > >>> MFC after: 1 week > >>> > >>> Modified: > >>> head/sys/powerpc/powerpc/trap.c > >>> > >>> Modified: head/sys/powerpc/powerpc/trap.c > >>> ============================================================================== > >>> --- head/sys/powerpc/powerpc/trap.c Sat Mar 9 03:15:09 > >>> 2019 (r344959) +++ head/sys/powerpc/powerpc/trap.c > >>> Sat Mar 9 03:18:37 2019 (r344960) @@ -546,6 +546,7 @@ > >>> printtrap(u_int vector, struct trapframe *frame, int i printf(" > >>> current msr = 0x%" PRIxPTR "\n", mfmsr()); printf(" > >>> lr = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr, > >>> frame->lr - (register_t)(__startkernel - KERNBASE)); > >>> + printf(" frame = %p\n", frame); > >>> printf(" curthread = %p\n", curthread); > >> > >> Some of those are printed with %PRIxPTR, some with %p. Perhaps > >> this inconsistency can be avoided? > >> > >> ./danfe > > > > PRIxPTR is for printing a pointer-like value that's not a pointer. > > The other values printed are of type register_t, not void *. > > Normally in FreeBSD sources we cast it to void * and use %p rather > than the PRI* macros FWIW. > Fair enough. I can add that to my TODO list. I have to fix the msr printing anyway, since the msr itself is not a pointer, but it's printed as such. May as well clean them all up. - Justin