From owner-svn-src-projects@FreeBSD.ORG Fri May 11 10:47:01 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4ED3F106564A; Fri, 11 May 2012 10:47:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 9D5808FC08; Fri, 11 May 2012 10:47:00 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q4BAkpdB008838; Fri, 11 May 2012 13:46:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q4BAkmCi034520; Fri, 11 May 2012 13:46:48 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q4BAkm31034519; Fri, 11 May 2012 13:46:48 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 11 May 2012 13:46:48 +0300 From: Konstantin Belousov To: Mateusz Guzik Message-ID: <20120511104648.GM2358@deviant.kiev.zoral.com.ua> References: <201203170318.q2H3ITdI047893@svn.freebsd.org> <20120317085116.GC1340@garage.freebsd.pl> <20120317161050.GI75778@deviant.kiev.zoral.com.ua> <4FA8FFB9.7090002@freebsd.org> <20120508095631.GV2358@deviant.kiev.zoral.com.ua> <4FA94609.3060306@freebsd.org> <20120510103105.GG2358@deviant.kiev.zoral.com.ua> <4FABC64F.3060502@freebsd.org> <20120510115857.GH2358@deviant.kiev.zoral.com.ua> <20120510164519.GA13258@pcbsd-2342.semihalf.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="23eOHpR5vYWIDA3o" Content-Disposition: inline In-Reply-To: <20120510164519.GA13258@pcbsd-2342.semihalf.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-projects@freebsd.org, Grzegorz Bernacki , src-committers@freebsd.org Subject: Re: svn commit: r233072 - projects/nand/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2012 10:47:01 -0000 --23eOHpR5vYWIDA3o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 10, 2012 at 06:45:19PM +0200, Mateusz Guzik wrote: > http://people.freebsd.org/~raj/patches/misc/vfs_highdirtybuf.diff >=20 > callbacks are expected to increase flushed counter if they happend to > flush some buffers. I do not think this is right. You need to call a routine when getnewblk() is unable to find a buffer to recycle. As I understand, in your situation with lot of managed buffers, the dirty queue could be just empty. >=20 > Example proof-of-concept (will be cleaned up) change for nandfs: > http://people.freebsd.org/~raj/patches/misc/nandfs_vfs_highdirtybuf.diff >=20 > Does this look reasonable? >=20 > --=20 > Mateusz Guzik --23eOHpR5vYWIDA3o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+s7hYACgkQC3+MBN1Mb4i+QACfTBH8z4JVPDHuSaTcwutFQD3S yvYAoNCvUl9fvyGvd5hB+ILx3M4EPKw+ =LqdC -----END PGP SIGNATURE----- --23eOHpR5vYWIDA3o--