From owner-cvs-src@FreeBSD.ORG Mon Aug 23 19:24:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A65E816A4CE; Mon, 23 Aug 2004 19:24:50 +0000 (GMT) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 15D8F43D45; Mon, 23 Aug 2004 19:24:50 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from dhcp50.pn.xcllnt.net (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.12.11/8.12.11) with ESMTP id i7NJOnIj012204; Mon, 23 Aug 2004 12:24:50 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp50.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp50.pn.xcllnt.net (8.13.1/8.13.1) with ESMTP id i7NJOn6G001108; Mon, 23 Aug 2004 12:24:49 -0700 (PDT) (envelope-from marcel@dhcp50.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp50.pn.xcllnt.net (8.13.1/8.13.1/Submit) id i7NJOnGk001107; Mon, 23 Aug 2004 12:24:49 -0700 (PDT) (envelope-from marcel) Date: Mon, 23 Aug 2004 12:24:48 -0700 From: Marcel Moolenaar To: Doug Rabson Message-ID: <20040823192448.GA1074@dhcp50.pn.xcllnt.net> References: <200408231530.i7NFU5bu082414@repoman.freebsd.org> <1093283234.16672.2.camel@builder02.qubesoft.com> <20040823181827.GA706@dhcp50.pn.xcllnt.net> <200408231958.41081.dfr@nlsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200408231958.41081.dfr@nlsystems.com> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen tls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Aug 2004 19:24:51 -0000 On Mon, Aug 23, 2004 at 07:58:41PM +0100, Doug Rabson wrote: > > > > > > This is the real fix for the static binaries segfaulting on alpha. > > > With this we could re-add the change to crt1.c which enables TLS > > > for static binaries. Given that we don't yet fully support TLS for > > > alpha in either rtld or libpthread, I don't propose to change > > > lib/csu/alpha/crt1.c again for 5.3. > > > > However, if we revert the backout of crt1.c, then we know that all > > shared executables will work the moment we fix rtld and libpthread. > > If we keep the call to _init_tls() removed from crt1.c then every > > binary linked on a 5.3 machine needs to be relinked the moment we > > do add proper TLS support. So, to minimize (future) burden I suggest > > we change crt1.c back for 5.3 as well. Otherwise this will just be > > another exception on Alpha... > > But then again, none of those static binaries are likely to include TLS > (since its currently disabled for alpha). Dynamic binaries are not > affected because when rtld gets involved, it handles the TLS > initialisation istelf - _init_tls() is only used for static binaries > and is empty for dynamic. Doh... you're right. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net