From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Dec 27 18:20:12 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4560E16A4CE for ; Mon, 27 Dec 2004 18:20:12 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01D0743D3F for ; Mon, 27 Dec 2004 18:20:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBRIKBTD089378 for ; Mon, 27 Dec 2004 18:20:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBRIKB86089377; Mon, 27 Dec 2004 18:20:11 GMT (envelope-from gnats) Resent-Date: Mon, 27 Dec 2004 18:20:11 GMT Resent-Message-Id: <200412271820.iBRIKB86089377@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Julien Gabel Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8368B16A4CE for ; Mon, 27 Dec 2004 18:17:38 +0000 (GMT) Received: from smtp.thilelli.net (smtp.thilelli.net [213.41.129.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C63743D54 for ; Mon, 27 Dec 2004 18:17:38 +0000 (GMT) (envelope-from jgabel@thilelli.net) Received: from localhost (localhost [127.0.0.1]) by bento.thilelli.net (Postfix) with ESMTP id 5474C78C93; Mon, 27 Dec 2004 19:17:37 +0100 (CET) Received: from bento.thilelli.net ([127.0.0.1]) by localhost (bento.thilelli.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 67337-01-7; Mon, 27 Dec 2004 19:17:36 +0100 (CET) Received: from titeuf.thilelli.net (titeuf.thilelli.net [192.168.1.19]) by bento.thilelli.net (Postfix) with ESMTP id C67CC78C91; Mon, 27 Dec 2004 19:17:36 +0100 (CET) Received: by titeuf.thilelli.net (Postfix, from userid 1001) id B74077301B; Mon, 27 Dec 2004 19:17:36 +0100 (CET) Message-Id: <20041227181736.B74077301B@titeuf.thilelli.net> Date: Mon, 27 Dec 2004 19:17:36 +0100 (CET) From: Julien Gabel To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/75550: [PATCH] Make more visible printing when defining vars before make-ing X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Julien Gabel List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Dec 2004 18:20:12 -0000 >Number: 75550 >Category: ports >Synopsis: [PATCH] Make more visible printing when defining vars before make-ing >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Dec 27 18:20:11 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Julien Gabel >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: System: FreeBSD bento.thilelli.net 5.2.1-RELEASE-p13 FreeBSD 5.2.1-RELEASE-p13 #0: Mon Dec 27 13:35:53 CET 2004 root@bento.thilelli.net:/usr/obj/usr/src/sys/BENTO i386 >Description: After a fresh installation of mail/dspam (/var/db/pkg/dspam-3.2.3.20041218.2100_1), some printing when defining vars before make-ing may be more informative. In this patch, the following modification were made: - Print the default value (with vars) _and_ the defined value if any; - Correct a little mistake in the default value of DSPAM_HOME. >How-To-Repeat: Go to /usr/ports/mail/dspam and type 'make extract' will suffice. >Fix: # diff -ruN /usr/ports/mail/dspam/Makefile.orig /usr/ports/mail/dspam/Makefile --- /usr/ports/mail/dspam/Makefile.orig Mon Dec 27 17:04:51 2004 +++ /usr/ports/mail/dspam/Makefile Mon Dec 27 18:09:01 2004 @@ -522,15 +522,15 @@ @${ECHO_CMD} "Define vars below before make-ing if you need:" @${ECHO_CMD} "" - @${ECHO_CMD} "SIGNATURE_LIFE (default 15)" - @${ECHO_CMD} "DSPAM_OWNER (default: root)" - @${ECHO_CMD} "DSPAM_GROUP (default: mail)" + @${ECHO_CMD} "SIGNATURE_LIFE = ${SIGNATURE_LIFE} (default 15)" + @${ECHO_CMD} "DSPAM_OWNER = ${DSPAM_OWNER} (default: root)" + @${ECHO_CMD} "DSPAM_GROUP = ${DSPAM_GROUP} (default: mail)" @${ECHO_CMD} "DSPAM_MODE" - @${ECHO_CMD} "DSPAM_HOME (default: ${_VAR_DIR}/dspam)" + @${ECHO_CMD} "DSPAM_HOME = ${DSPAM_HOME} (default: ${_VAR_DIR}/db/dspam)" @${ECHO_CMD} "DSPAM_HOME_OWNER" @${ECHO_CMD} "DSPAM_HOME_GROUP" - @${ECHO_CMD} "DSPAM_HOME_MODE (default: 0660)" - @${ECHO_CMD} "LOG_DIR (default: ${_VAR_DIR}/log/dspam)" + @${ECHO_CMD} "DSPAM_HOME_MODE = ${DSPAM_HOME_MODE} (default: 0660)" + @${ECHO_CMD} "LOG_DIR = ${LOG_DIR} (default: ${_VAR_DIR}/log/dspam)" @${ECHO_CMD} "QUARANTINE_AGENT (default: mail.local)" . if defined(WITH_CGI) @${ECHO_CMD} "Define CGI_PATH before make-ing if you need the CGI files" >Release-Note: >Audit-Trail: >Unformatted: accordinf to our needs.