From owner-freebsd-net@FreeBSD.ORG Thu Dec 18 16:15:38 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7874A26A; Thu, 18 Dec 2014 16:15:38 +0000 (UTC) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0070C1218; Thu, 18 Dec 2014 16:15:38 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id b13so2070424wgh.17; Thu, 18 Dec 2014 08:15:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=hudcimyO+SjkOAFe80ACr/xPof3gHyhzLSihODzrVM0=; b=Wqm6qV8B1AASg/9a8LwSE520cEMF37AsoTT4RVqUj8tIn1qdF1H2NewaoEt1fpKDCS 0KqKXVvgUqF9fSAiK5hge5i/qIp3rGR2BtkXEXq0W95Sji7q2EZcmr4uRya4O66ruwhu f5rtx4FFbKjcA8Fd6wfKOwBh8ZDpEIEPqCNPIsMx3C/i3K01VY4iyzV+6E+DSB4bjKhs Y+JLOsjnNOWQgtq8i3GcmjFOhJYdvHblrQe5KUwXAD8O180FLGWi2QR0JiAbgYbvm31q 0gOFjfRjkc3eMDTZfJ/lebEX2i28263Tag5bAuBysifCKJLKdpSI40O+7cLaAE4OkJln v87Q== MIME-Version: 1.0 X-Received: by 10.180.90.133 with SMTP id bw5mr6760011wib.50.1418919333479; Thu, 18 Dec 2014 08:15:33 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.17.129 with HTTP; Thu, 18 Dec 2014 08:15:33 -0800 (PST) In-Reply-To: References: <1A44709E-7D0C-4932-8A28-383EAC3F340B@dpdtech.com> <9AE69175-92D9-49FA-A651-119C7046A1FA@dpdtech.com> <5480D8EF.9000804@egr.msu.edu> <3D993418-E632-44BA-8FE2-2F3F34188F20@dpdtech.com> <34276C9E-CAEF-4E3F-AA2A-568F2D3099EC@dpdtech.com> <2BCFC9D3-3B7D-421F-9FDA-0C4E1018F8F5@dpdtech.com> Date: Thu, 18 Dec 2014 09:15:33 -0700 X-Google-Sender-Auth: 59mTmWFuF3RjI8HsPEehU0u36qM Message-ID: Subject: Re: FreeBSD 10-stable (r274577) LACP / IEEE 802.3ad with TP-Link TL-SG2008 - not working From: Alan Somers To: Craig Rodrigues Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Net , Adam McDougall , "David P. Discher" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 16:15:38 -0000 On Wed, Dec 17, 2014 at 10:11 PM, Craig Rodrigues wrote: > On Wed, Dec 17, 2014 at 9:08 PM, Craig Rodrigues > wrote: >> >> >> >> On Wed, Dec 17, 2014 at 5:36 PM, David P. Discher wrote: >>> >>> >>> Yeah, Alan - will do ... if I decided to look into more. That is why I was >>> looking for spec on LACP. One side is doing it wrong. FreeBSD is looking >>> for a LACPDU of exactly sizeof ( struct lacpdu ) which is 124 bytes. The >>> TP-Link is sending a PDU of 128 bytes. I was hoping someone would know off >>> hand what the spec says, if the PDU "should be" or "must be". >>> >> >> >> I think you have stumbled across a valid problem in the FreeBSD code. I >> don't have access >> to 802.3ad-2000, but this might give you some clues: >> http://kb.juniper.net/InfoCenter/index?page=content&id=KB17674 >> >> I would also look at the source code of wireshark to be sure. wireshark >> has a sample capture of LACP packets here: >> >> http://wiki.wireshark.org/LinkAggregationControlProtocol >> >> > And here: > > http://www-01.ibm.com/support/docview.wss?uid=isg1VM64842 Good find, Craig. Also, I found the full LACPDU definition. It's in section 5.4.2.2, page 33, of the 802.1ax-2008 spec that I linked to. You can see the 4-byte FCS field at the end. Does your tp_link[4] field look like an FCS? If so, you need to figure out why it's propagating all the way up to the LACP level. -Alan