From owner-p4-projects@FreeBSD.ORG Wed Sep 12 23:19:24 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id EE54E16A476; Wed, 12 Sep 2007 23:19:23 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFD3716A417; Wed, 12 Sep 2007 23:19:23 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from heff.fud.org.nz (203-109-251-39.static.bliink.ihug.co.nz [203.109.251.39]) by mx1.freebsd.org (Postfix) with ESMTP id 1B2C913C468; Wed, 12 Sep 2007 23:19:23 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: by heff.fud.org.nz (Postfix, from userid 1001) id 85D761CC26; Thu, 13 Sep 2007 11:05:47 +1200 (NZST) Date: Thu, 13 Sep 2007 11:05:47 +1200 From: Andrew Thompson To: Kip Macy Message-ID: <20070912230547.GB63121@heff.fud.org.nz> References: <200709120832.l8C8WLlm085731@repoman.freebsd.org> <20070912150017.GA3553@garage.freebsd.pl> <3bbf2fe10709121530h6d0681c4xa247fe7d31cb2c2e@mail.gmail.com> <20070912223833.GC4909@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Cc: Attilio Rao , Perforce Change Reviews , Pawel Jakub Dawidek , Kip Macy Subject: Re: PERFORCE change 126330 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2007 23:19:24 -0000 On Wed, Sep 12, 2007 at 03:49:55PM -0700, Kip Macy wrote: > Andrew Thompson explicitly asked for the possibility of shared acquisition. I dont have a use for shared acquisition at the moment but I imagine it could be handy. > On 9/12/07, Pawel Jakub Dawidek wrote: > > On Thu, Sep 13, 2007 at 12:30:26AM +0200, Attilio Rao wrote: > > > 2007/9/12, Kip Macy : > > > > On 9/12/07, Pawel Jakub Dawidek wrote: > > > > > On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote: > > > > > > http://perforce.freebsd.org/chv.cgi?CH=126330 > > > > > > > > > > > > Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36 > > > > > > > > > > > > convert radix node head and route locks from mutexes to rwlocks > > > > > [...] > > > > > > rt->rt_flags |= RTF_LLINFO; > > > > > > - callout_init_mtx(&la->la_timer, &rt->rt_mtx, > > > > > > - CALLOUT_RETURNUNLOCKED); > > > > > > + callout_init_rwlock(&la->la_timer, &rt->rt_lock, > > > > > > + CALLOUT_RETURNUNLOCKED_RW); > > > > > > > > > > > > > > > > Kip, don't add callout_init_rwlock() to the tree. I've > > > > > callout_init_lock() implemented that operates on any lock type, just > > > > > like condvar(9). > > > > > > > > point me to a diff > > > > > > I'm courious to know another thing instead. > > > As like condvar() works, it is allowed to before release and later > > > acquire the lock. > > > This scheme let you acquire the lock again following the previous > > > pattern for sx and rw locks (if for example you had a rwlock mantained > > > in write mode you will acquire it in the same way). > > > This is not applicable to callout, instead, as you have the lock > > > 'blank', so with double-kind locks (like rw and sx) how do you lock > > > it? > > > > Always write/exclusive. > > > > -- > > Pawel Jakub Dawidek http://www.wheel.pl > > pjd@FreeBSD.org http://www.FreeBSD.org > > FreeBSD committer Am I Evil? Yes, I Am! > > > >