From owner-cvs-ports@FreeBSD.ORG Tue Sep 20 16:50:04 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F27E106566B for ; Tue, 20 Sep 2011 16:50:04 +0000 (UTC) (envelope-from lx@redundancy.redundancy.org) Received: from redundancy.redundancy.org (75-101-96-57.dsl.static.sonic.net [75.101.96.57]) by mx1.freebsd.org (Postfix) with SMTP id 0DF798FC15 for ; Tue, 20 Sep 2011 16:50:03 +0000 (UTC) Received: (qmail 61616 invoked by uid 1001); 20 Sep 2011 16:50:27 -0000 Date: Tue, 20 Sep 2011 09:50:27 -0700 From: David Thiel To: Sahil Tandon Message-ID: <20110920165002.GG27781@redundancy.redundancy.org> References: <201109200252.p8K2q1ma037870@repoman.freebsd.org> <20110920053052.GF27781@redundancy.redundancy.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-OpenPGP-Key-fingerprint: 482A 8C46 C844 7E7C 8CBC 2313 96EE BEE5 1F4B CA13 X-OpenPGP-Key-available: http://redundancy.redundancy.org/lx.gpg X-Face: %H~{$1~NOw1y#%mM6{|4:/, Eitan Adler , "ports-committers@FreeBSD.org" Subject: Re: cvs commit: ports/x11/iceauth Makefile distinfo ports/x11/libXcursor Makefile distinfo ports/x11/libXdmcp Makefile distinfo ports/x11/libxkbfile Makefile distinfo ports/x11/rstart Makefile distinfo ports/x11/smproxy Makefile distinfo ... X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2011 16:50:04 -0000 On Tue, Sep 20, 2011 at 08:44:00AM -0400, Sahil Tandon wrote: > > "x11" isn't a valid value for LICENSE, and setting it thus causes > > the build to fail for most of the ports touched by this commit. You > > can see the allowed values in bsd.licenses.db.mk - in this case, it > > should be "MIT". > > You are 100% correct. Bapt fixed this a little while ago. For the > record, this was completely my fault and an unforgivable oversight > during my review of eadler's commit. I'm sorry. No worries. To be fair, portlint doesn't actually seem to check this, and it's not documented in the porter's handbook, so proper use of LICENSE isn't exactly obvious.