From owner-freebsd-x11@FreeBSD.ORG  Tue Dec 31 19:50:01 2013
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: freebsd-x11@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A0C7A405
 for <freebsd-x11@smarthost.ysv.freebsd.org>;
 Tue, 31 Dec 2013 19:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8A51F1B14
 for <freebsd-x11@smarthost.ysv.freebsd.org>;
 Tue, 31 Dec 2013 19:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBVJo1fK054858
 for <freebsd-x11@freefall.freebsd.org>; Tue, 31 Dec 2013 19:50:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBVJo18W054843;
 Tue, 31 Dec 2013 19:50:01 GMT (envelope-from gnats)
Date: Tue, 31 Dec 2013 19:50:01 GMT
Message-Id: <201312311950.rBVJo18W054843@freefall.freebsd.org>
To: freebsd-x11@FreeBSD.org
Cc: 
From: John Marino <freebsd.contact@marino.st>
Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all
 have same error
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: John Marino <freebsd.contact@marino.st>
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11/>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Dec 2013 19:50:01 -0000

The following reply was made to PR ports/184952; it has been noted by GNATS.

From: John Marino <freebsd.contact@marino.st>
To: Niclas Zeising <zeising@freebsd.org>
Cc: bug-followup@FreeBSD.org, freebsd@marino.st, kwm@freebsd.org, 
 Baptiste Daroussin <bapt@freebsd.org>
Subject: Re: ports/184952: x11-servers/xorg-server: Slave port makefiles all
 have same error
Date: Tue, 31 Dec 2013 20:43:00 +0100

 On 12/31/2013 19:23, Niclas Zeising wrote:
 > This breaks detection of WITH_NEW_XORG= and needs to be reverted.
 > Regards!
 
 Then your WITH_NEW_XORG detection is wrong.
 Having bsd.ports.options.mk loaded multiple times causes problems, such
 as applying the same patches multiple times (if patches are present).
 It was detected independently by myself and kwm.
 
 By the way, the "detection" broke DragonFly too because of the use of
 OSVERSION without OPSYS.
 
 I'd say the detection is what needs to be reverted.
 
 (DragonFly has /etc/defaults/make.conf so we put WITH_NEW_XORG defaults
 there)
 
 John