From owner-freebsd-current@freebsd.org  Thu Nov 10 11:22:08 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72230C3A4BE;
 Thu, 10 Nov 2016 11:22:08 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 8FDB7155F;
 Thu, 10 Nov 2016 11:22:06 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA20375;
 Thu, 10 Nov 2016 13:22:05 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1c4nQj-0006dE-4Y; Thu, 10 Nov 2016 13:22:05 +0200
Subject: Re: SM bus ioctls incorrect in FreeBSD 11
To: Lewis Donzis <lew@perftech.com>
References: <06929AC5-D350-4236-A813-56C862B58174@perftech.com>
 <fe780e23-f014-1c84-b702-12727cd68ef0@FreeBSD.org>
 <1AA2BB21-0D6D-42F4-9CB2-3CBB00F389C6@perftech.com>
Cc: freebsd-current@FreeBSD.org,
 "freebsd-arch@freebsd.org" <freebsd-arch@FreeBSD.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <6a337a1d-45e7-d7f2-140c-7499c67b6c0a@FreeBSD.org>
Date: Thu, 10 Nov 2016 13:21:09 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1AA2BB21-0D6D-42F4-9CB2-3CBB00F389C6@perftech.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Nov 2016 11:22:08 -0000

On 14/10/2016 18:51, Lewis Donzis wrote:
> Our opinion doesn’t count for much, but I like 2 or 4.  Option 1 would
> essentially obviate the entire purpose of changing the structure.  Option 2
> basically finishes the job and makes it work properly.  Option 3 is, as you
> say, unappealing.  I have no problem with Option 4, obviously we can change
> our code back to the old way, but assuming there was a good reason for this
> change in the first place, Option 2 seems more logical.
> 
> But whatever y’all decide is fine with us, we’ll just change code to match at
> the appropriate time.

Anyone interested in the issue, could you please take a look at this review?
https://reviews.freebsd.org/D8430

Thank you.

-- 
Andriy Gapon