Date: Thu, 10 Nov 2016 13:21:09 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Lewis Donzis <lew@perftech.com> Cc: freebsd-current@FreeBSD.org, "freebsd-arch@freebsd.org" <freebsd-arch@FreeBSD.org> Subject: Re: SM bus ioctls incorrect in FreeBSD 11 Message-ID: <6a337a1d-45e7-d7f2-140c-7499c67b6c0a@FreeBSD.org> In-Reply-To: <1AA2BB21-0D6D-42F4-9CB2-3CBB00F389C6@perftech.com> References: <06929AC5-D350-4236-A813-56C862B58174@perftech.com> <fe780e23-f014-1c84-b702-12727cd68ef0@FreeBSD.org> <1AA2BB21-0D6D-42F4-9CB2-3CBB00F389C6@perftech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/10/2016 18:51, Lewis Donzis wrote: > Our opinion doesn’t count for much, but I like 2 or 4. Option 1 would > essentially obviate the entire purpose of changing the structure. Option 2 > basically finishes the job and makes it work properly. Option 3 is, as you > say, unappealing. I have no problem with Option 4, obviously we can change > our code back to the old way, but assuming there was a good reason for this > change in the first place, Option 2 seems more logical. > > But whatever y’all decide is fine with us, we’ll just change code to match at > the appropriate time. Anyone interested in the issue, could you please take a look at this review? https://reviews.freebsd.org/D8430 Thank you. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a337a1d-45e7-d7f2-140c-7499c67b6c0a>