From owner-svn-src-head@FreeBSD.ORG  Mon Nov 17 22:46:05 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0B161530;
 Mon, 17 Nov 2014 22:46:05 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D89481D2;
 Mon, 17 Nov 2014 22:46:04 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0E379B939;
 Mon, 17 Nov 2014 17:46:03 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Dmitry Chagin <dchagin@freebsd.org>
Subject: Re: svn commit: r274635 - head/sys/dev/pci
Date: Mon, 17 Nov 2014 17:45:23 -0500
Message-ID: <2245618.H2SPKlpWdS@ralph.baldwin.cx>
User-Agent: KMail/4.14.2 (FreeBSD/10.1-PRERELEASE; KDE/4.14.2; amd64; ; )
In-Reply-To: <201411172025.sAHKPLMl055666@svn.freebsd.org>
References: <201411172025.sAHKPLMl055666@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 17 Nov 2014 17:46:03 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2014 22:46:05 -0000

On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote:
> Author: dchagin
> Date: Mon Nov 17 20:25:21 2014
> New Revision: 274635
> URL: https://svnweb.freebsd.org/changeset/base/274635
> 
> Log:
>   Use the correct device as the power_for_sleep() method
>   always pass request up to parent bridge.
> 
>   Reviewed by:	jhb
>   MFC after:	1 week
>   xMFC:		r274386,r274397

Hmm, I had misread this diff as being another instance of what Adrian had 
found.  I think this is actually not correct.  The parent of a pci device 
('dev' here) is a pciX device.  pciX devices do not implement the 
PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke 
Adrian's Asus laptop as now it will always use D3 again and ignore _SxD.

You said that this change fixed your laptop, yes?  Did it work before Adrian's 
change in r274386 and break afterwards?

-- 
John Baldwin