From owner-svn-ports-head@freebsd.org Fri Jul 5 23:51:28 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAFC815D7DF4; Fri, 5 Jul 2019 23:51:28 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 723D38F797; Fri, 5 Jul 2019 23:51:28 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 437A317DBC; Fri, 5 Jul 2019 23:51:28 +0000 (UTC) From: Jan Beich To: Alexey Dokuchaev Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r505908 - in head/sysutils: . netevent netevent/files References: <201907051908.x65J88nq064712@repo.freebsd.org> <20190705212539.GA21664@FreeBSD.org> Date: Sat, 06 Jul 2019 01:51:25 +0200 In-Reply-To: <20190705212539.GA21664@FreeBSD.org> (Alexey Dokuchaev's message of "Fri, 5 Jul 2019 21:25:39 +0000") Message-ID: <36jk-f3b6-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 723D38F797 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.95 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_SHORT(-0.95)[-0.950,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jul 2019 23:51:29 -0000 Alexey Dokuchaev writes: > On Fri, Jul 05, 2019 at 07:08:08PM +0000, Jan Beich wrote: > >> New Revision: 505908 >> URL: https://svnweb.freebsd.org/changeset/ports/505908 >> >> Log: >> sysutils/netevent: add new port > > It would be nice to briefly describe it, even in the commit log. Those who bother reading commit logs also read actual diffs. Copy-pasting pkg-descr won't answer "why" the port was added or provide more input about "what" was done. A better commit message can only be written by whoever made the change. Doing so requires a DVCS like Git or if provided separately. Obviously, the reviewer can still improve commit message by fixing wording/typos, adjust formatting and maybe elaborate some confusing points. >> +COMMENT= Tool for sharing uinput devices with other machines > > What's "uinput"? 'U' and 'I' letters are adjacent on my keyboard, is > this a typo? evdev(4) created from userland. https://www.kernel.org/doc/html/latest/input/uinput.html >> +OPTIONS_SUB= MANPAGES > > That's the same as OPTIONS_SUB=yes. I also like the idea of putting > specific options on the OPTIONS_SUB list, but someone on portmgr@ had > told me they won't do this. portlint doesn't complain, so stylistically anything can replace "yes". This time maintainer wanted to annotate why OPTIONS_SUB is needed. As a committer I don't see the point of enforcing my (or your) bias. >> Added: head/sysutils/netevent/pkg-plist >> @@ -0,0 +1,3 @@ >> +bin/netevent >> +%%MANPAGES%%man/man1/netevent.1.gz >> +%%PORTEXAMPLES%%%%EXAMPLESDIR%%/simple.ne2 > > Three-line pkg-plist is a good candidate for PLIST_FILES/PORTDOCS/ > PORTEXAMPLES. Assuming pkg-plist won't grow in future. As changing required maintainer approval but the benefit was subjective I've dropped the idea.