From owner-svn-src-all@freebsd.org Sun Mar 12 14:07:06 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC03DD09741; Sun, 12 Mar 2017 14:07:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC30D14FD; Sun, 12 Mar 2017 14:07:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id v190so16162728pfb.0; Sun, 12 Mar 2017 07:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rxJRkaeJfAoUmFV6Mr/iEpc3SryLnvquE3YtNw7gRgY=; b=CNeEVSmlKYUCJjgUtimQPKtLmuIB8hcPSJeFPgiQZU2GqXLn/I5HWAQdpuLJqYS6AE 5i1Lb9bTEh8YZd3rFmQ3PJqLnJyA6qLp+75ucma68YbwnuRYzp4kfsXaswjoi8W8mzhS gCu79Dihl4v5Wc5vK50+v5V1Q52c71yIpMC0puJ+wIzedgHQqTCM3SoBMPN6fnnYv8fr KB+5OY9dsurPPZCKbeVyXp5Idhv5STJK2V5rkXXq+N1O7Xlg69NoHRBNEjL1PgtkZ3NR ek1oWFBsoMQbOsC2jBIKddE/oDksVIb1FU3vEQkka+d0by9qRvTq6mxtuuIs80qfwMMJ X3sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rxJRkaeJfAoUmFV6Mr/iEpc3SryLnvquE3YtNw7gRgY=; b=E956WJko2ZGm9U1nZTF+GhvxXnpQGRikTR/teQofxGDIEd2JMErcnKJgGZWuiZ0PUc +/kncnDV2eWvsEXt7HAprgjpkcoRZT+rnUUjGKtvbj4YpH6dSZSKjSyPgYkwzFZgc5W2 1eFxTOWbFSPBr0Qk8wBK+5xHplrARnueBsmxEEmex/iNG3YwXcLSED9B5ZuUtGiEE9bg +/No/IQQlpnTLb+x8m67XtYisS8RYSCp67QjIM5Vcsy37TAWdWYTn0FjshQj4jpzbpqy C8H46Al6dUPTfWpg/6xyrM/qDXqHyCvVAQ6kAEYyFFmesyjkJPwWdtR83izn/N7HQarK /x4A== X-Gm-Message-State: AMke39nSLLwxTF0mxsQPRU/jdYFKmJGRIHwumRCeM/dqifnRWS2/B30S9QFBBs2pSh2fWA== X-Received: by 10.84.128.98 with SMTP id 89mr41270995pla.24.1489327626185; Sun, 12 Mar 2017 07:07:06 -0700 (PDT) Received: from [192.168.20.13] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 80sm28632746pfn.61.2017.03.12.07.07.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Mar 2017 07:07:05 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r308996 - head/lib/libfetch From: Ngie Cooper X-Mailer: iPhone Mail (14D27) In-Reply-To: <86shmid9ct.fsf@desk.des.no> Date: Sun, 12 Mar 2017 07:07:05 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <92F67C24-E539-4810-9014-DCC019DD0CBB@gmail.com> References: <201611221330.uAMDU7fg052989@repo.freebsd.org> <93505FD7-FB42-4BD5-834C-6F73EFD9B1CF@gmail.com> <86shmid9ct.fsf@desk.des.no> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 14:07:07 -0000 > On Mar 12, 2017, at 04:26, Dag-Erling Sm=C3=B8rgrav wrote: >=20 > "Ngie Cooper (yaneurabeya)" writes: >> Hi Bjoern, >=20 > No, that was my father :) :D.. >> Shouldn=E2=80=99t this be strrchr instead of strchr since you=E2=80=99= re >> scanning for the service from the right side of the host, >> e.g. =E2=80=9Cfoo:service=E2=80=9D or =E2=80=9C[::1]:service=E2=80=9D? Th= is code would match index 3 >> in the first example, but it would match index 2 in the second >> example. >=20 > Correct, although it may be slightly more complicated, which is why I > didn't immediately jump on it when bz@ pointed it out. I'm working on > it right now. Awesome! Great teamwork! -Ngie=