From nobody Sun May 15 17:30:05 2022 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 629EE1ADF30F for ; Sun, 15 May 2022 17:30:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L1Tt63Qtdz3mNd for ; Sun, 15 May 2022 17:30:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa30.google.com with SMTP id o132so6465990vko.11 for ; Sun, 15 May 2022 10:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yDq4IIQnDxrH6FST8xs69XJzCRVzJ2pl0euDQHHv/Bg=; b=h6zlQ1T9Yt2Y+BlJUODXEHp6xV2z/Pjb1K55Qjkpz/C9DPpaLX5iF+UI3HjZjWdKEQ EFa8FDW8f8DY3iYXW5kbwavfYxMgpZzc+GvSqgHsE+Ox6t+iugX4Om/JJ6VGuT+K4o9V z/k4faIJPlOTC30xsF/4M340D5mjpFhe3sHCwupupyopaqN5poeDbMWeSTPdUtwd1VPS +mshPQqyDv/IBX7lWpWnakk2lGpQfpA7Ydt8dxx4PfnLpi6HZ8PUiTSk92H4DnfH0bM5 rpgbT6BqOCCmV8brj9yXFKx2O1atpeKnRj/haamTmX1lPUf9iuN9eZP2Dn9y00xOOGfT AJTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yDq4IIQnDxrH6FST8xs69XJzCRVzJ2pl0euDQHHv/Bg=; b=YiQBTCLqIz/5g+0COf5IEKuUyBzV32p9gxjnqog2M9R2DJ62C2OqRPPbhetjVzJWfL 8TP/OlZ5niLDYmTLUDL7mrqoUjbYKxJec0NkOVXpwoTICN/Zwhc2ve+RzwmDWjtl69ri qPSzBMYwYAVD30rcxYw4KG557Z5YdqqmqKBIuR2oxS00+HgGlzo0Oyw8c6ERogWkWoGw +unq2zKq3jE/8KfkVKKZc4TJSsbBlkced22bU3IRrAhbjwHbYKsdzYQ1kVgHm8wRFo7R g3lALm95HqSq18/lD+bO3IOBCbJI5qhsb/nFoeaU8X3qnA+92FublBqEhEyuaHJUWIJt aKig== X-Gm-Message-State: AOAM5323+PaoaKZQkaxrgEgUqLr4RLtM/b2fwz9QSj+t9DBlDpVnk6Vl 0smLg4L8CQ0jesjTmrdYUmRWYJ8X3LQI6lA07k5ceg== X-Google-Smtp-Source: ABdhPJw5y68/tiHzVTz2qANBmEXMBOZun+QC6H491sk9GVHuS8hCY3sMGCRdcWFW0URS3nh24vIZ1lhJigB3JEimYig= X-Received: by 2002:a05:6122:2229:b0:32d:1642:b58b with SMTP id bb41-20020a056122222900b0032d1642b58bmr4583867vkb.27.1652635816454; Sun, 15 May 2022 10:30:16 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sun, 15 May 2022 11:30:05 -0600 Message-ID: Subject: Re: Changes to stat ABI To: Paul Floyd Cc: FreeBSD Hackers Content-Type: multipart/alternative; boundary="000000000000c884d705df10426c" X-Rspamd-Queue-Id: 4L1Tt63Qtdz3mNd X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=h6zlQ1T9; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::a30) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a30:from]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MLMMJ_DEST(0.00)[freebsd-hackers]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com] X-ThisMailContainsUnwantedMimeParts: N --000000000000c884d705df10426c Content-Type: text/plain; charset="UTF-8" ino64 has gone into the tree. The stat structure layout changed. 69921123490b99c2588b0c743bc4af32bbe6601c went into the tree a while ago, but maybe recently enough to mess this up. Author: Konstantin Belousov Date: Tue May 23 09:29:05 2017 +0000 Commit the 64-bit inode project. Extend the ino_t, dev_t, nlink_t types to 64-bit ints. Modify struct dirent layout to add d_off, increase the size of d_fileno to 64-bits, increase the size of d_namlen to 16-bits, and change the required alignment. Increase struct statfs f_mntfromname[] and f_mntonname[] array length MNAMELEN to 1024. On Sat, May 14, 2022 at 2:10 PM Paul Floyd wrote: > Hi > > > Has anything changed in the way that the libc functions in the stat > family are compiled on FreeBSD 13.1 amd64 with clang 13? > > > I'm getting a few Valgrind regression test failures related to this: > > FreeBSD 13 / clang 11 > > ==84746== Syscall param fstatat(flag) contains uninitialised byte(s) > ==84746== at 0x49942EA: ??? (in /lib/libc.so.7) > ==84746== by 0x499018B: fstatat (in /lib/libc.so.7) > ==84746== by 0x201E7D: main (stat.c:67) > > FreeBSD 13.1 / clang 13 > > ==57383== Syscall param fstatat(flag) contains uninitialised byte(s) > ==57383== at 0x499239A: ??? (in /lib/libc.so.7) > ==57383== by 0x201E57: main (stat.c:67) > > A+ > > Paul > > > > --000000000000c884d705df10426c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
ino64 has gone into the tree. The stat structure layout ch= anged.=C2=A069921123490b99c2588b0c743bc4af32bbe6601c went into the tree a w= hile ago, but maybe recently enough to mess this up.

Aut= hor: Konstantin Belousov <kib@FreeBSD.org>
Date: =C2=A0 Tue May 23= 09:29:05 2017 +0000

=C2=A0 =C2=A0 Commit the 64-bit inode project.<= br>
=C2=A0 =C2=A0 Extend the ino_t, dev_t, nlink_t types to 64-bit ints.= =C2=A0 Modify
=C2=A0 =C2=A0 struct dirent layout to add d_off, increase = the size of d_fileno
=C2=A0 =C2=A0 to 64-bits, increase the size of d_na= mlen to 16-bits, and change
=C2=A0 =C2=A0 the required alignment.=C2=A0 = Increase struct statfs f_mntfromname[] and
=C2=A0 =C2=A0 f_mntonname[] a= rray length MNAMELEN to 1024.

On Sat, May 14, 2022 at 2:10 PM Paul= Floyd <paulf2718@gmail.com&g= t; wrote:
Hi


Has anything changed in the way that the libc functions in the stat
family are compiled on FreeBSD 13.1 amd64 with clang 13?


I'm getting a few Valgrind regression test failures related to this:
FreeBSD 13 / clang 11

=3D=3D84746=3D=3D Syscall param fstatat(flag) contains uninitialised byte(s= )
=3D=3D84746=3D=3D=C2=A0=C2=A0=C2=A0 at 0x49942EA: ??? (in /lib/libc.so.7) =3D=3D84746=3D=3D=C2=A0=C2=A0=C2=A0 by 0x499018B: fstatat (in /lib/libc.so.= 7)
=3D=3D84746=3D=3D=C2=A0=C2=A0=C2=A0 by 0x201E7D: main (stat.c:67)

FreeBSD 13.1 / clang 13

=3D=3D57383=3D=3D Syscall param fstatat(flag) contains uninitialised byte(s= )
=3D=3D57383=3D=3D=C2=A0=C2=A0=C2=A0 at 0x499239A: ??? (in /lib/libc.so.7) =3D=3D57383=3D=3D=C2=A0=C2=A0=C2=A0 by 0x201E57: main (stat.c:67)

A+

Paul



--000000000000c884d705df10426c--