From owner-svn-src-all@FreeBSD.ORG Mon Dec 17 22:23:57 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ED8FB923; Mon, 17 Dec 2012 22:23:56 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7F1BC8FC0C; Mon, 17 Dec 2012 22:23:56 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi5so49836pad.13 for ; Mon, 17 Dec 2012 14:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=R2TkEe3bg1QWkIvIPEgmsK0vExMAa5SyjYoC6UxxSyQ=; b=r3bAcUFUnlzrHpnaSa+YrmLPkiQt0Yq+TJ+7MCBqaYUksKV4YqS+IBEHOLhsOnFp76 x8aZJe2HL5XNQFAm4266py6cVQZrMDd+AGNtsGCJl14LPlVrF5Ep1kD0SE8tPk2AiBN6 lP8L9xcN4eaa7Jj8qlkvlhW/xIHSGHkK5q6lQJ8MUAeVrRnFYqLUunbCzYfRTEuRliJ0 y/Fd/aLnaJzDlpeH//y0mtE4ATLBxscJeKLnOvOkUKzm+RQIgHucG//yYN1AsR+GlKgL tLYLLYGR+YIGTPQI8j1jkZdbj+80AqM4HaAw+bgjtGuZn47ISf2sz9M/HrNcqzZhFGIz yyZA== Received: by 10.68.137.167 with SMTP id qj7mr47031702pbb.148.1355783035719; Mon, 17 Dec 2012 14:23:55 -0800 (PST) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.112.58]) by mx.google.com with ESMTPS id d2sm120337paw.19.2012.12.17.14.23.53 (version=SSLv3 cipher=OTHER); Mon, 17 Dec 2012 14:23:54 -0800 (PST) Sender: Navdeep Parhar Message-ID: <50CF9B77.6090006@FreeBSD.org> Date: Mon, 17 Dec 2012 14:23:51 -0800 From: Navdeep Parhar User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: svn commit: r244112 - head/sys/kern References: <201212110708.qBB78EWx025288@svn.freebsd.org> <50CBC285.7060307@mu.org> <20121215161414.V1029@besplex.bde.org> <201212171439.27297.jhb@freebsd.org> <50CF8CE7.4020906@mu.org> <50CF92F0.5020904@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 17 Dec 2012 22:34:38 +0000 Cc: Alfred Perlstein , src-committers@freebsd.org, John Baldwin , svn-src-all@freebsd.org, Alfred Perlstein , Andriy Gapon , Gleb Smirnoff , Robert Watson , Bruce Evans , svn-src-head@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 22:23:57 -0000 On 12/17/12 14:02, Adrian Chadd wrote: > On 17 December 2012 13:47, Andriy Gapon wrote: > >> But you see, the following is still illogical _to me_. > > And this is the core of the problem. > > A lot of developers are interpreting the KASSERT() conditions as an > invariant condition that, if in any way enabled, should be completely > trusted, believed and cause an immediate panic(). > > However, we leave them out on shipping, production kernels. Why's > that? Because the contract here is "the code should never hit these > situations, so we don't bother checking." > > It's totally understandable at this point why there's such a huge > amount of confusion here. On one hand we have a construct that allows > the developer to enforce correct behaviour and panic early if it gets > caught out; on the other hand we totally ignore all of that in > shipping, production kernels. > > Why are they there, if we just ship production releases with > INVARIANTS disabled? Read the section titled "NOTE TO PEOPLE WHO THINK THAT FreeBSD 10.x IS SLOW:" in /usr/src/UPDATING if you're wondering why. Regards, Navdeep