From owner-svn-src-projects@freebsd.org Sat Mar 2 03:11:31 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8B0F150E051 for ; Sat, 2 Mar 2019 03:11:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2A9C371B51; Sat, 2 Mar 2019 03:11:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f169.google.com with SMTP id d14so22135054ljl.9; Fri, 01 Mar 2019 19:11:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUq4RqJ9EbWS7fTTZQwcGqaOZ4v9ZpI8O6OzU5HMHIo=; b=WnlF6IMAdpLx5zeSk7P0YlFENk2G7YPgtQjGx62MJcVhqV/QS/nH/AU9OT0zeKNXBD S7bi6EkUBJe9FdftNNeN6z3zv9LFeiFUGOPmnz+JWtyIHEdX1c8KpJPxVmc6YLnh6tZT rRw+KvwDjvP7go/ZbzYlRvz1M2kFdrvV/0nI8bR/zyEUvFOwWdw+yLBx83jAyb0rblRr KWkPJIErcHZboQLBjv6yvRFI3t07brjOWFTE73XOYSGNU3Yg5QeCITk+aWmzG9IJHqRP wgfG5GNrGjuQ0HVo7AqtOeM2T1TZd89Q3YKZfxihJV/FkqoMUedr2zupPujWiz+Z6dBT XzZA== X-Gm-Message-State: APjAAAXoojMdvUoFRDsRWuD9ucHxNXzWj3Ae9PHm5smOwqyGqjtEzNzf t7t5WTxkviGpO2xJmPClqFbu/dIIC++gu0VIe7J15A== X-Google-Smtp-Source: APXvYqwFftf6fQuDGsbnP3Xt18IPcfYI9WSB+VK9pABsJ0fgWopXj9WXA7MwejKvlBbm2RyRVgBdbBwgdz4H37KX2Eo= X-Received: by 2002:a2e:99c9:: with SMTP id l9mr4271535ljj.60.1551487033257; Fri, 01 Mar 2019 16:37:13 -0800 (PST) MIME-Version: 1.0 References: <201903012353.x21Nr5do051752@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Fri, 1 Mar 2019 17:37:01 -0700 Message-ID: Subject: Re: svn commit: r344715 - in projects/fuse2: etc/mtree tests/sys/fs tests/sys/fs/fuse To: Enji Cooper Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2A9C371B51 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.81 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.81)[-0.810,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Mar 2019 03:11:31 -0000 On Fri, Mar 1, 2019 at 5:28 PM Enji Cooper wrote: > > > > On Mar 1, 2019, at 15:53, Alan Somers wrote: > > > > Author: asomers > > Date: Fri Mar 1 23:53:05 2019 > > New Revision: 344715 > > URL: https://svnweb.freebsd.org/changeset/base/344715 > > > > Log: > > Begin a fuse(4) test suite > > > > It only tests the kernel portion of fuse, not the userspace portion (which > > comes from sysutils/fusefs-libs). The kernel-userspace interface is > > de-facto standardized, and this test suite seeks to validate FreeBSD's > > implementation. > > > > It uses GoogleMock to substitute for a userspace daemon and validate the > > kernel's behavior in response to filesystem access. GoogleMock is > > convenient because it can validate the order, number, and arguments of each > > operation, and return canned responses. > > > > But that also means that the test suite must use GoogleTest, since > > GoogleMock is incompatible with atf-c++ and atf.test.mk does not allow C++ > > programs to use atf-c. > > > > This commit adds the first 10 test cases out of an estimated 130 total. > > > > PR: 235775, 235773 > > Hi Alan! > Could you please use SetupEnvironment to ensure that /dev/fuse exists and is accessible? This is something I needing to be done with the zfsd tests too, IIRC. > Thanks so much :)!! > -Enji What's the advantage to doing it that way as opposed to using the regular SetUp function? -Alan