From owner-svn-ports-head@FreeBSD.ORG  Fri Jan 17 23:26:43 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D8E5E591;
 Fri, 17 Jan 2014 23:26:43 +0000 (UTC)
Received: from mail-la0-x236.google.com (mail-la0-x236.google.com
 [IPv6:2a00:1450:4010:c03::236])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id CC13615B4;
 Fri, 17 Jan 2014 23:26:42 +0000 (UTC)
Received: by mail-la0-f54.google.com with SMTP id y1so4181186lam.27
 for <multiple recipients>; Fri, 17 Jan 2014 15:26:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=7cTUAQyyez5ZJcY+ZylGvisOp6IV+AQ1qtRL47vYttc=;
 b=FTs7RYuPDS24qRf01rIgJIg24Vu7ydnKzmeZUcpb5YusrasiDHnXCs7qG4QJ4ZcpaF
 v0/KBCgjZA+g/xj7S95edJsOG+gqrwd7e42JLdAVBPrcRlSnfjTOJn5k5IJWGgEhdQkV
 Cz1JBfyiZoXGsnhdDypiANQCnK07T4RcYZRuwIxSaUBqa+Nnavbf8lh5kjlwvjNetnpx
 FZ8cs10pipU9tN5ncHyfAfJI7m95Xv2fMqJ6WvsXtr6FzmoE6VxWAruFKkoeTctn1AF6
 5AcopBWJ3Z4YdnxDIO3HFsHYIetysWZWGWf4a25jTbMqDdY3IlTiclMs4DPw8Bl8Z+wh
 aK6w==
MIME-Version: 1.0
X-Received: by 10.152.19.170 with SMTP id g10mr2438631lae.9.1390001200786;
 Fri, 17 Jan 2014 15:26:40 -0800 (PST)
Received: by 10.114.2.146 with HTTP; Fri, 17 Jan 2014 15:26:40 -0800 (PST)
In-Reply-To: <20140117185451.GA64598@FreeBSD.org>
References: <201401171656.s0HGuFpw077232@svn.freebsd.org>
 <20140117185451.GA64598@FreeBSD.org>
Date: Sat, 18 Jan 2014 07:26:40 +0800
Message-ID: <CAFY+yE=wpKDF+cK5UG2VnTzFGdZOXzrzAe=0EyO=-foR7nj9rg@mail.gmail.com>
Subject: Re: svn commit: r340073 - head/graphics/gphoto2
From: Martin Wilke <miwi.fbsd@gmail.com>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.17
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 23:26:43 -0000

http://www.freebsd.org/cgi/query-pr-summary.cgi?responsible=danfe thank you


On Sat, Jan 18, 2014 at 2:54 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Fri, Jan 17, 2014 at 04:56:15PM +0000, Martin Wilke wrote:
> > New Revision: 340073
> > URL: http://svnweb.freebsd.org/changeset/ports/340073
> > QAT: https://qat.redports.org/buildarchive/r340073/
>
> (The following goes more to Kato and their ports sweatshop rather than
> to Martin; just picking one commit of many.)
>
> > -USES=                gmake pkgconfig
> >  USE_BZIP2=   yes
> > +USES=                gmake pkgconfig
>
> This change is 1) gratuitous; 2) goes against most common practice of
> placing USES above other USE_* knobs; 3) destroys my work of r322593.
>
> > +post-patch:
> > +     @${REINPLACE_CMD} -e \
> > +             's|-lpthread|-pthread|' \
> > +             ${WRKSRC}/configure
>
> This REINPLACE_CMD statement perfectly fits one 80-char line, why break
> it up?
>
> >  post-install:
> > -     ${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR}
> > +     (cd ${WRKSRC} && ${INSTALL_DATA} NEWS ${STAGEDIR}${DOCSDIR})
>
> Gratuitous; two commands instead of one; longer and less readable.  Why?
>
> ./danfe
>